Skip to content

Commit 4bc77b2

Browse files
diandersrobherring
authored andcommitted
dt-bindings: phy: qcom-qusb2: Fix defaults
The defaults listed in the bindings don't match what the code is actually doing. Presumably existing users care more about keeping existing behavior the same, so change the bindings to match the code in Linux. The "qcom,preemphasis-level" default has been wrong for quite a long time (May 2018). The other two were recently added. As some evidence that these values are wrong, this is from the Linux driver: - qcom,preemphasis-level: sets "PORT_TUNE1", lower 2 bits. Driver programs PORT_TUNE1 to 0x30 by default and (0x30 & 0x3) = 0. - qcom,bias-ctrl-value: sets "PLL_BIAS_CONTROL_2", lower 6 bits. Driver programs PLL_BIAS_CONTROL_2 to 0x20 by default and (0x20 & 0x3f) = 0x20 = 32. - qcom,hsdisc-trim-value: sets "PORT_TUNE2", lower 2 bits. Driver programs PORT_TUNE2 to 0x29 by default and (0x29 & 0x3) = 1. Fixes: 1e6f134 ("dt-bindings: phy: qcom-qusb2: Add support for overriding Phy tuning parameters") Fixes: a8b70cc ("dt-bindings: phy-qcom-usb2: Add support to override tuning values") Signed-off-by: Douglas Anderson <[email protected]> Reviewed-by: Matthias Kaehlcke <[email protected]> Signed-off-by: Rob Herring <[email protected]>
1 parent 2bdfd4f commit 4bc77b2

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ then:
9797
- $ref: /schemas/types.yaml#/definitions/uint32
9898
- minimum: 0
9999
maximum: 63
100-
default: 0
100+
default: 32
101101

102102
qcom,charge-ctrl-value:
103103
description:
@@ -130,7 +130,7 @@ then:
130130
- $ref: /schemas/types.yaml#/definitions/uint32
131131
- minimum: 0
132132
maximum: 3
133-
default: 2
133+
default: 0
134134

135135
qcom,preemphasis-width:
136136
description:
@@ -152,7 +152,7 @@ then:
152152
- $ref: /schemas/types.yaml#/definitions/uint32
153153
- minimum: 0
154154
maximum: 3
155-
default: 0
155+
default: 1
156156

157157
required:
158158
- compatible

0 commit comments

Comments
 (0)