Skip to content

Commit 4bdd394

Browse files
anjutsudhakarmpe
authored andcommitted
powerpc/powernv: Re-enable imc trace-mode in kernel
commit <249fad734a25> ""powerpc/perf: Disable trace_imc pmu" disables IMC(In-Memory Collection) trace-mode in kernel, since frequent mode switching between accumulation mode and trace mode via the spr LDBAR in the hardware can trigger a checkstop(system crash). Patch to re-enable imc-trace mode in kernel. The previous patch(1/2) in this series will address the mode switching issue by implementing a global lock, and will restrict the usage of accumulation and trace-mode at a time. Signed-off-by: Anju T Sudhakar <[email protected]> Signed-off-by: Michael Ellerman <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent a36e8ba commit 4bdd394

File tree

1 file changed

+1
-8
lines changed

1 file changed

+1
-8
lines changed

arch/powerpc/platforms/powernv/opal-imc.c

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -268,14 +268,7 @@ static int opal_imc_counters_probe(struct platform_device *pdev)
268268
domain = IMC_DOMAIN_THREAD;
269269
break;
270270
case IMC_TYPE_TRACE:
271-
/*
272-
* FIXME. Using trace_imc events to monitor application
273-
* or KVM thread performance can cause a checkstop
274-
* (system crash).
275-
* Disable it for now.
276-
*/
277-
pr_info_once("IMC: disabling trace_imc PMU\n");
278-
domain = -1;
271+
domain = IMC_DOMAIN_TRACE;
279272
break;
280273
default:
281274
pr_warn("IMC Unknown Device type \n");

0 commit comments

Comments
 (0)