Skip to content

Commit 4c05433

Browse files
Zhu Lingshanmstsirkin
authored andcommitted
vDPA: dont change vq irq after DRIVER_OK
IRQ of a vq is not expected to be changed in a DRIVER_OK ~ !DRIVER_OK period for irq offloading purposes. Place this comment at the side of bus ops get_vq_irq than in set_status in vhost_vdpa. Signed-off-by: Zhu Lingshan <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Michael S. Tsirkin <[email protected]>
1 parent 46af9ad commit 4c05433

File tree

2 files changed

+1
-1
lines changed

2 files changed

+1
-1
lines changed

drivers/vhost/vdpa.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,6 @@ static long vhost_vdpa_set_status(struct vhost_vdpa *v, u8 __user *statusp)
172172

173173
ops->set_status(vdpa, status);
174174

175-
/* vq irq is not expected to be changed once DRIVER_OK is set */
176175
if ((status & VIRTIO_CONFIG_S_DRIVER_OK) && !(status_old & VIRTIO_CONFIG_S_DRIVER_OK))
177176
for (i = 0; i < nvqs; i++)
178177
vhost_vdpa_setup_vq_irq(v, i);

include/linux/vdpa.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -186,6 +186,7 @@ struct vdpa_config_ops {
186186
u64 (*get_vq_state)(struct vdpa_device *vdev, u16 idx);
187187
struct vdpa_notification_area
188188
(*get_vq_notification)(struct vdpa_device *vdev, u16 idx);
189+
/* vq irq is not expected to be changed once DRIVER_OK is set */
189190
int (*get_vq_irq)(struct vdpa_device *vdv, u16 idx);
190191

191192
/* Device ops */

0 commit comments

Comments
 (0)