Skip to content

Commit 4c2e9ba

Browse files
ambarusvinodkoul
authored andcommitted
dmaengine: at_hdmac: Do not print messages on console while holding the lock
The descriptor was already removed from the transfer list, there's no reason to keep the channel lock while printing desc info, thus do the prints without holding the lock. Signed-off-by: Tudor Ambarus <[email protected]> Acked-by: Nicolas Ferre <[email protected]> Link: https://lore.kernel.org/r/[email protected] Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Vinod Koul <[email protected]>
1 parent 3f134c9 commit 4c2e9ba

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/dma/at_hdmac.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -549,6 +549,8 @@ static void atc_handle_error(struct at_dma_chan *atchan)
549549
atc_dostart(atchan, desc);
550550
}
551551

552+
spin_unlock_irqrestore(&atchan->lock, flags);
553+
552554
/*
553555
* KERN_CRITICAL may seem harsh, but since this only happens
554556
* when someone submits a bad physical address in a
@@ -564,8 +566,6 @@ static void atc_handle_error(struct at_dma_chan *atchan)
564566
list_for_each_entry(child, &bad_desc->tx_list, desc_node)
565567
atc_dump_lli(atchan, &child->lli);
566568

567-
spin_unlock_irqrestore(&atchan->lock, flags);
568-
569569
/* Pretend the descriptor completed successfully */
570570
atc_chain_complete(atchan, bad_desc);
571571
}

0 commit comments

Comments
 (0)