Skip to content

Commit 4c36f65

Browse files
jhnikulaalexandrebelloni
authored andcommitted
i3c: mipi-i3c-hci: Fix missing xfer->completion in hci_cmd_v1_daa()
Due to missing completion object for the ENTDAA command transfer in the hci_cmd_v1_daa() the wait_for_completion_timeout() will obviously timeout even the transfer itself may succeed. Fix this by setting the xfer->completion to the already initialized completion object. Signed-off-by: Jarkko Nikula <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Alexandre Belloni <[email protected]>
1 parent b8806e0 commit 4c36f65

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/i3c/master/mipi-i3c-hci/cmd_v1.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -332,6 +332,7 @@ static int hci_cmd_v1_daa(struct i3c_hci *hci)
332332
CMD_A0_DEV_COUNT(1) |
333333
CMD_A0_ROC | CMD_A0_TOC;
334334
xfer->cmd_desc[1] = 0;
335+
xfer->completion = &done;
335336
hci->io->queue_xfer(hci, xfer, 1);
336337
if (!wait_for_completion_timeout(&done, HZ) &&
337338
hci->io->dequeue_xfer(hci, xfer, 1)) {

0 commit comments

Comments
 (0)