Skip to content

Commit 4c64d70

Browse files
Xinghui Likwilczynski
authored andcommitted
PCI: vmd: Fix inconsistent indentation in vmd_resume()
The if-statement within the vmd_resume() function has an inconsistent indentation that leads to a compile time warning. Thus, correct the inconsistent indentation. While at it, remove the if-statement completely, which will make the code simpler. This was detected by Smatch: drivers/pci/controller/vmd.c:1066 vmd_resume() warn: inconsistent indenting No functional changes are intended. [kwilczynski: use correct tags, commit log] Suggested-by: Christoph Hellwig <[email protected]> Link: https://lore.kernel.org/linux-pci/[email protected] Reported-by: Dan Carpenter <[email protected]> Signed-off-by: Xinghui Li <[email protected]> Signed-off-by: Krzysztof Wilczyński <[email protected]>
1 parent 0bb80ec commit 4c64d70

File tree

1 file changed

+1
-4
lines changed
  • drivers/pci/controller

1 file changed

+1
-4
lines changed

drivers/pci/controller/vmd.c

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1078,10 +1078,7 @@ static int vmd_resume(struct device *dev)
10781078
struct vmd_dev *vmd = pci_get_drvdata(pdev);
10791079
int err, i;
10801080

1081-
if (vmd->irq_domain)
1082-
vmd_set_msi_remapping(vmd, true);
1083-
else
1084-
vmd_set_msi_remapping(vmd, false);
1081+
vmd_set_msi_remapping(vmd, !!vmd->irq_domain);
10851082

10861083
for (i = 0; i < vmd->msix_count; i++) {
10871084
err = devm_request_irq(dev, vmd->irqs[i].virq,

0 commit comments

Comments
 (0)