Skip to content

Commit 4c6abef

Browse files
cdleonardchanwoochoi
authored andcommitted
PM / devfreq: Fix handling dev_pm_qos_remove_request result
The dev_pm_qos_remove_request function can return 1 if "aggregated constraint value has changed" so only negative values should be reported as errors. Fixes: 27dbc54 ("PM / devfreq: Use PM QoS for sysfs min/max_freq") Reported-by: Dan Carpenter <[email protected]> Signed-off-by: Leonard Crestez <[email protected]> Signed-off-by: Chanwoo Choi <[email protected]>
1 parent 3bb5ee9 commit 4c6abef

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/devfreq/devfreq.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -705,13 +705,13 @@ static void devfreq_dev_release(struct device *dev)
705705

706706
if (dev_pm_qos_request_active(&devfreq->user_max_freq_req)) {
707707
err = dev_pm_qos_remove_request(&devfreq->user_max_freq_req);
708-
if (err)
708+
if (err < 0)
709709
dev_warn(dev->parent,
710710
"Failed to remove max_freq request: %d\n", err);
711711
}
712712
if (dev_pm_qos_request_active(&devfreq->user_min_freq_req)) {
713713
err = dev_pm_qos_remove_request(&devfreq->user_min_freq_req);
714-
if (err)
714+
if (err < 0)
715715
dev_warn(dev->parent,
716716
"Failed to remove min_freq request: %d\n", err);
717717
}

0 commit comments

Comments
 (0)