Skip to content

Commit 4c9d410

Browse files
Nicolas Schiermasahir0y
authored andcommitted
initramfs: Check timestamp to prevent broken cpio archive
Cpio format reserves 8 bytes for an ASCII representation of a time_t timestamp. While 2106-02-07 06:28:15 UTC (time_t = 0xffffffff) is still some years in the future, a poorly chosen date string for KBUILD_BUILD_TIMESTAMP, converted into seconds since the epoch, might lead to exceeded cpio timestamp limits that result in a broken cpio archive. Add timestamp checks to prevent overrun of the 8-byte cpio header field. My colleague Thomas Kühnel discovered the behaviour, when we accidentally fed SOURCE_DATE_EPOCH to KBUILD_BUILD_TIMESTAMP as is: some timestamps (e.g. 1607420928 = 2021-12-08 9:48:48 UTC) will be interpreted by `date` as a valid date specification of science fictional times (here: year 160742). Even though this is bad input for KBUILD_BUILD_TIMESTAMP, it should not break the initramfs cpio format. Signed-off-by: Nicolas Schier <[email protected]> Cc: Thomas Kühnel <[email protected]> Signed-off-by: Masahiro Yamada <[email protected]>
1 parent 6947fd9 commit 4c9d410

File tree

1 file changed

+16
-0
lines changed

1 file changed

+16
-0
lines changed

usr/gen_init_cpio.c

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -320,6 +320,12 @@ static int cpio_mkfile(const char *name, const char *location,
320320
goto error;
321321
}
322322

323+
if (buf.st_mtime > 0xffffffff) {
324+
fprintf(stderr, "%s: Timestamp exceeds maximum cpio timestamp, clipping.\n",
325+
location);
326+
buf.st_mtime = 0xffffffff;
327+
}
328+
323329
filebuf = malloc(buf.st_size);
324330
if (!filebuf) {
325331
fprintf (stderr, "out of memory\n");
@@ -551,6 +557,16 @@ int main (int argc, char *argv[])
551557
}
552558
}
553559

560+
/*
561+
* Timestamps after 2106-02-07 06:28:15 UTC have an ascii hex time_t
562+
* representation that exceeds 8 chars and breaks the cpio header
563+
* specification.
564+
*/
565+
if (default_mtime > 0xffffffff) {
566+
fprintf(stderr, "ERROR: Timestamp too large for cpio format\n");
567+
exit(1);
568+
}
569+
554570
if (argc - optind != 1) {
555571
usage(argv[0]);
556572
exit(1);

0 commit comments

Comments
 (0)