Skip to content

Commit 4ca6c1a

Browse files
author
Peter Zijlstra
committed
sched,acpi_pad: Convert to sched_set_fifo*()
Because SCHED_FIFO is a broken scheduler model (see previous patches) take away the priority field, the kernel can't possibly make an informed decision. In this case, use fifo_low, because it only cares about being above SCHED_NORMAL. Effectively no change in behaviour. XXX: this driver is still complete crap; why isn't it using proper idle injection or at the very least play_idle() ? Cc: [email protected] Signed-off-by: Peter Zijlstra (Intel) <[email protected]> Reviewed-by: Ingo Molnar <[email protected]>
1 parent dbc6d0d commit 4ca6c1a

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

drivers/acpi/acpi_pad.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -136,12 +136,11 @@ static unsigned int idle_pct = 5; /* percentage */
136136
static unsigned int round_robin_time = 1; /* second */
137137
static int power_saving_thread(void *data)
138138
{
139-
struct sched_param param = {.sched_priority = 1};
140139
int do_sleep;
141140
unsigned int tsk_index = (unsigned long)data;
142141
u64 last_jiffies = 0;
143142

144-
sched_setscheduler(current, SCHED_RR, &param);
143+
sched_set_fifo_low(current);
145144

146145
while (!kthread_should_stop()) {
147146
unsigned long expire_time;

0 commit comments

Comments
 (0)