Skip to content

Commit 4cd8371

Browse files
krzkkuba-moo
authored andcommitted
nfc: fix potential NULL pointer deref in nfc_genl_dump_ses_done
The done() netlink callback nfc_genl_dump_ses_done() should check if received argument is non-NULL, because its allocation could fail earlier in dumpit() (nfc_genl_dump_ses()). Fixes: ac22ac4 ("NFC: Add a GET_SE netlink API") Signed-off-by: Krzysztof Kozlowski <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent fd79a0c commit 4cd8371

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

net/nfc/netlink.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1394,8 +1394,10 @@ static int nfc_genl_dump_ses_done(struct netlink_callback *cb)
13941394
{
13951395
struct class_dev_iter *iter = (struct class_dev_iter *) cb->args[0];
13961396

1397-
nfc_device_iter_exit(iter);
1398-
kfree(iter);
1397+
if (iter) {
1398+
nfc_device_iter_exit(iter);
1399+
kfree(iter);
1400+
}
13991401

14001402
return 0;
14011403
}

0 commit comments

Comments
 (0)