Skip to content

Commit 4cf006b

Browse files
neilbrownbrauner
authored andcommitted
nfsd: drop fh_update() from S_IFDIR branch of nfsd_create_locked()
nfsd_create_locked() doesn't need to explicitly call fh_update(). On success (which is the only time that fh_update() matters at all), nfsd_create_setattr() will be called and it will call fh_update(). This extra call is not harmful, but is not necessary. Signed-off-by: NeilBrown <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Christian Brauner <[email protected]>
1 parent 3ff6c87 commit 4cf006b

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

fs/nfsd/vfs.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1505,11 +1505,8 @@ nfsd_create_locked(struct svc_rqst *rqstp, struct svc_fh *fhp,
15051505
}
15061506
dput(resfhp->fh_dentry);
15071507
resfhp->fh_dentry = dget(d);
1508-
err = fh_update(resfhp);
15091508
dput(dchild);
15101509
dchild = d;
1511-
if (err)
1512-
goto out;
15131510
}
15141511
break;
15151512
case S_IFCHR:

0 commit comments

Comments
 (0)