Skip to content

Commit 4d17448

Browse files
Kanchan Joshiaxboe
authored andcommitted
nvme: pass ubuffer as an integer
This is a prep patch. Modify nvme_submit_user_cmd and nvme_map_user_request to take ubuffer as plain integer argument, and do away with nvme_to_user_ptr conversion in callers. Signed-off-by: Anuj Gupta <[email protected]> Signed-off-by: Kanchan Joshi <[email protected]> Reviewed-by: Christoph Hellwig <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jens Axboe <[email protected]>
1 parent 3798754 commit 4d17448

File tree

1 file changed

+12
-11
lines changed

1 file changed

+12
-11
lines changed

drivers/nvme/host/ioctl.c

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -83,9 +83,10 @@ static struct request *nvme_alloc_user_request(struct request_queue *q,
8383
return req;
8484
}
8585

86-
static int nvme_map_user_request(struct request *req, void __user *ubuffer,
86+
static int nvme_map_user_request(struct request *req, u64 ubuffer,
8787
unsigned bufflen, void __user *meta_buffer, unsigned meta_len,
88-
u32 meta_seed, void **metap, bool vec)
88+
u32 meta_seed, void **metap, struct io_uring_cmd *ioucmd,
89+
bool vec)
8990
{
9091
struct request_queue *q = req->q;
9192
struct nvme_ns *ns = q->queuedata;
@@ -94,8 +95,8 @@ static int nvme_map_user_request(struct request *req, void __user *ubuffer,
9495
void *meta = NULL;
9596
int ret;
9697

97-
ret = blk_rq_map_user_io(req, NULL, ubuffer, bufflen, GFP_KERNEL, vec,
98-
0, 0, rq_data_dir(req));
98+
ret = blk_rq_map_user_io(req, NULL, nvme_to_user_ptr(ubuffer), bufflen,
99+
GFP_KERNEL, vec, 0, 0, rq_data_dir(req));
99100

100101
if (ret)
101102
goto out;
@@ -124,7 +125,7 @@ static int nvme_map_user_request(struct request *req, void __user *ubuffer,
124125
}
125126

126127
static int nvme_submit_user_cmd(struct request_queue *q,
127-
struct nvme_command *cmd, void __user *ubuffer,
128+
struct nvme_command *cmd, u64 ubuffer,
128129
unsigned bufflen, void __user *meta_buffer, unsigned meta_len,
129130
u32 meta_seed, u64 *result, unsigned timeout, bool vec)
130131
{
@@ -142,7 +143,7 @@ static int nvme_submit_user_cmd(struct request_queue *q,
142143
req->timeout = timeout;
143144
if (ubuffer && bufflen) {
144145
ret = nvme_map_user_request(req, ubuffer, bufflen, meta_buffer,
145-
meta_len, meta_seed, &meta, vec);
146+
meta_len, meta_seed, &meta, NULL, vec);
146147
if (ret)
147148
return ret;
148149
}
@@ -226,7 +227,7 @@ static int nvme_submit_io(struct nvme_ns *ns, struct nvme_user_io __user *uio)
226227
c.rw.appmask = cpu_to_le16(io.appmask);
227228

228229
return nvme_submit_user_cmd(ns->queue, &c,
229-
nvme_to_user_ptr(io.addr), length,
230+
io.addr, length,
230231
metadata, meta_len, lower_32_bits(io.slba), NULL, 0,
231232
false);
232233
}
@@ -280,7 +281,7 @@ static int nvme_user_cmd(struct nvme_ctrl *ctrl, struct nvme_ns *ns,
280281
timeout = msecs_to_jiffies(cmd.timeout_ms);
281282

282283
status = nvme_submit_user_cmd(ns ? ns->queue : ctrl->admin_q, &c,
283-
nvme_to_user_ptr(cmd.addr), cmd.data_len,
284+
cmd.addr, cmd.data_len,
284285
nvme_to_user_ptr(cmd.metadata), cmd.metadata_len,
285286
0, &result, timeout, false);
286287

@@ -326,7 +327,7 @@ static int nvme_user_cmd64(struct nvme_ctrl *ctrl, struct nvme_ns *ns,
326327
timeout = msecs_to_jiffies(cmd.timeout_ms);
327328

328329
status = nvme_submit_user_cmd(ns ? ns->queue : ctrl->admin_q, &c,
329-
nvme_to_user_ptr(cmd.addr), cmd.data_len,
330+
cmd.addr, cmd.data_len,
330331
nvme_to_user_ptr(cmd.metadata), cmd.metadata_len,
331332
0, &cmd.result, timeout, vec);
332333

@@ -512,9 +513,9 @@ static int nvme_uring_cmd_io(struct nvme_ctrl *ctrl, struct nvme_ns *ns,
512513
req->timeout = d.timeout_ms ? msecs_to_jiffies(d.timeout_ms) : 0;
513514

514515
if (d.addr && d.data_len) {
515-
ret = nvme_map_user_request(req, nvme_to_user_ptr(d.addr),
516+
ret = nvme_map_user_request(req, d.addr,
516517
d.data_len, nvme_to_user_ptr(d.metadata),
517-
d.metadata_len, 0, &meta, vec);
518+
d.metadata_len, 0, &meta, ioucmd, vec);
518519
if (ret)
519520
return ret;
520521
}

0 commit comments

Comments
 (0)