Skip to content

Commit 4d2d4ce

Browse files
Andrew JonesMarc Zyngier
authored andcommitted
KVM: arm64: Drop type input from kvm_put_guest
We can use typeof() to avoid the need for the type input. Suggested-by: Marc Zyngier <[email protected]> Signed-off-by: Andrew Jones <[email protected]> Signed-off-by: Marc Zyngier <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent 2dbd780 commit 4d2d4ce

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

arch/arm64/kvm/pvtime.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ void kvm_update_stolen_time(struct kvm_vcpu *vcpu)
3232
steal_le = cpu_to_le64(steal);
3333
idx = srcu_read_lock(&kvm->srcu);
3434
offset = offsetof(struct pvclock_vcpu_stolen_time, stolen_time);
35-
kvm_put_guest(kvm, base + offset, steal_le, u64);
35+
kvm_put_guest(kvm, base + offset, steal_le);
3636
srcu_read_unlock(&kvm->srcu, idx);
3737
}
3838

include/linux/kvm_host.h

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -749,25 +749,26 @@ int kvm_write_guest_offset_cached(struct kvm *kvm, struct gfn_to_hva_cache *ghc,
749749
int kvm_gfn_to_hva_cache_init(struct kvm *kvm, struct gfn_to_hva_cache *ghc,
750750
gpa_t gpa, unsigned long len);
751751

752-
#define __kvm_put_guest(kvm, gfn, offset, value, type) \
752+
#define __kvm_put_guest(kvm, gfn, offset, v) \
753753
({ \
754754
unsigned long __addr = gfn_to_hva(kvm, gfn); \
755-
type __user *__uaddr = (type __user *)(__addr + offset); \
755+
typeof(v) __user *__uaddr = (typeof(__uaddr))(__addr + offset); \
756756
int __ret = -EFAULT; \
757757
\
758758
if (!kvm_is_error_hva(__addr)) \
759-
__ret = put_user(value, __uaddr); \
759+
__ret = put_user(v, __uaddr); \
760760
if (!__ret) \
761761
mark_page_dirty(kvm, gfn); \
762762
__ret; \
763763
})
764764

765-
#define kvm_put_guest(kvm, gpa, value, type) \
765+
#define kvm_put_guest(kvm, gpa, v) \
766766
({ \
767767
gpa_t __gpa = gpa; \
768768
struct kvm *__kvm = kvm; \
769+
\
769770
__kvm_put_guest(__kvm, __gpa >> PAGE_SHIFT, \
770-
offset_in_page(__gpa), (value), type); \
771+
offset_in_page(__gpa), v); \
771772
})
772773

773774
int kvm_clear_guest_page(struct kvm *kvm, gfn_t gfn, int offset, int len);

0 commit comments

Comments
 (0)