Skip to content

Commit 4d9c3a6

Browse files
committed
Merge tag 'pci-v5.9-fixes-2' of git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci
Pull PCI fixes from Bjorn Helgaas: - Fix rockchip regression in rockchip_pcie_valid_device() (Lorenzo Pieralisi) - Add Pali Rohár as aardvark PCI maintainer (Pali Rohár) * tag 'pci-v5.9-fixes-2' of git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci: MAINTAINERS: Add Pali Rohár as aardvark PCI maintainer PCI: rockchip: Fix bus checks in rockchip_pcie_valid_device()
2 parents cb6f55a + 76a6b0b commit 4d9c3a6

File tree

2 files changed

+5
-7
lines changed

2 files changed

+5
-7
lines changed

MAINTAINERS

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13182,6 +13182,7 @@ F: drivers/firmware/pcdp.*
1318213182

1318313183
PCI DRIVER FOR AARDVARK (Marvell Armada 3700)
1318413184
M: Thomas Petazzoni <[email protected]>
13185+
M: Pali Rohár <[email protected]>
1318513186
1318613187
L: [email protected] (moderated for non-subscribers)
1318713188
S: Maintained

drivers/pci/controller/pcie-rockchip-host.c

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -71,16 +71,13 @@ static void rockchip_pcie_update_txcredit_mui(struct rockchip_pcie *rockchip)
7171
static int rockchip_pcie_valid_device(struct rockchip_pcie *rockchip,
7272
struct pci_bus *bus, int dev)
7373
{
74-
/* access only one slot on each root port */
75-
if (pci_is_root_bus(bus) && dev > 0)
76-
return 0;
77-
7874
/*
79-
* do not read more than one device on the bus directly attached
75+
* Access only one slot on each root port.
76+
* Do not read more than one device on the bus directly attached
8077
* to RC's downstream side.
8178
*/
82-
if (pci_is_root_bus(bus->parent) && dev > 0)
83-
return 0;
79+
if (pci_is_root_bus(bus) || pci_is_root_bus(bus->parent))
80+
return dev == 0;
8481

8582
return 1;
8683
}

0 commit comments

Comments
 (0)