Skip to content

Commit 4da3a54

Browse files
andrea-parrimartinkpetersen
authored andcommitted
Revert "scsi: storvsc: Validate length of incoming packet in storvsc_on_channel_callback()"
This reverts commit 3b8c72d. Dexuan reported a regression where StorVSC fails to probe a device (and where, consequently, the VM may fail to boot). The root-cause analysis led to a long-standing race condition that is exposed by the validation /commit in question. Let's put the new validation aside until a proper solution for that race condition is in place. Link: https://lore.kernel.org/r/[email protected] Fixes: 3b8c72d ("scsi: storvsc: Validate length of incoming packet in storvsc_on_channel_callback()") Cc: Dexuan Cui <[email protected]> Cc: "James E.J. Bottomley" <[email protected]> Cc: "Martin K. Petersen" <[email protected]> Cc: [email protected] Signed-off-by: Andrea Parri (Microsoft) <[email protected]> Signed-off-by: Martin K. Petersen <[email protected]>
1 parent 359db63 commit 4da3a54

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

drivers/scsi/storvsc_drv.c

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1246,11 +1246,6 @@ static void storvsc_on_channel_callback(void *context)
12461246
request = (struct storvsc_cmd_request *)
12471247
((unsigned long)desc->trans_id);
12481248

1249-
if (hv_pkt_datalen(desc) < sizeof(struct vstor_packet) - vmscsi_size_delta) {
1250-
dev_err(&device->device, "Invalid packet len\n");
1251-
continue;
1252-
}
1253-
12541249
if (request == &stor_device->init_request ||
12551250
request == &stor_device->reset_request) {
12561251
memcpy(&request->vstor_packet, packet,

0 commit comments

Comments
 (0)