PCI: switchtec: Simplify switchtec_dma_mrpc_isr()

bjorn-helgaas · bjorn-helgaas · commit 4e353ff40a83 · 2023-01-18T11:11:14.000-06:00
The "ret" variable in switchtec_dma_mrpc_isr() is superfluous. Remove it and just return the value. No functional change intended. Link: https://lore.kernel.org/r/20221216162126.207863-2-helgaas@kernel.org Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
diff --git a/drivers/pci/switch/switchtec.c b/drivers/pci/switch/switchtec.c
@@ -1480,15 +1480,13 @@ static irqreturn_t switchtec_event_isr(int irq, void *dev)
 static irqreturn_t switchtec_dma_mrpc_isr(int irq, void *dev)
 {
 	struct switchtec_dev *stdev = dev;
-	irqreturn_t ret = IRQ_NONE;
 
 	iowrite32(SWITCHTEC_EVENT_CLEAR |
 		  SWITCHTEC_EVENT_EN_IRQ,
 		  &stdev->mmio_part_cfg->mrpc_comp_hdr);
 	schedule_work(&stdev->mrpc_work);
 
-	ret = IRQ_HANDLED;
-	return ret;
+	return IRQ_HANDLED;
 }
 
 static int switchtec_init_isr(struct switchtec_dev *stdev)

Original file line number	Diff line number	Diff line change
`@@ -1480,15 +1480,13 @@ static irqreturn_t switchtec_event_isr(int irq, void *dev)`
`1480`	`1480`	`static irqreturn_t switchtec_dma_mrpc_isr(int irq, void *dev)`
`1481`	`1481`	`{`
`1482`	`1482`	`struct switchtec_dev *stdev = dev;`
`1483`		`- irqreturn_t ret = IRQ_NONE;`
`1484`	`1483`
`1485`	`1484`	`iowrite32(SWITCHTEC_EVENT_CLEAR \|`
`1486`	`1485`	`SWITCHTEC_EVENT_EN_IRQ,`
`1487`	`1486`	`&stdev->mmio_part_cfg->mrpc_comp_hdr);`
`1488`	`1487`	`schedule_work(&stdev->mrpc_work);`
`1489`	`1488`
`1490`		`- ret = IRQ_HANDLED;`
`1491`		`- return ret;`
	`1489`	`+ return IRQ_HANDLED;`
`1492`	`1490`	`}`
`1493`	`1491`
`1494`	`1492`	`static int switchtec_init_isr(struct switchtec_dev *stdev)`