Skip to content

Commit 4ea19ec

Browse files
ti_wilink_st.h: Replace zero-length array with flexible-array member
The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99: struct foo { int stuff; struct boo array[]; }; By making use of the mechanism above, we will get a compiler warning in case the flexible array does not occur last in the structure, which will help us prevent some kind of undefined behavior bugs from being inadvertently introduced[3] to the codebase from now on. Also, notice that, dynamic memory allocations won't be affected by this change: "Flexible array members have incomplete type, and so the sizeof operator may not be applied. As a quirk of the original implementation of zero-length arrays, sizeof evaluates to zero."[1] This issue was found with the help of Coccinelle. [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html [2] KSPP#21 [3] commit 7649773 ("cxgb3/l2t: Fix undefined behaviour") Signed-off-by: Gustavo A. R. Silva <[email protected]>
1 parent 16c3380 commit 4ea19ec

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

include/linux/ti_wilink_st.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -295,7 +295,7 @@ struct bts_header {
295295
u32 magic;
296296
u32 version;
297297
u8 future[24];
298-
u8 actions[0];
298+
u8 actions[];
299299
} __attribute__ ((packed));
300300

301301
/**
@@ -305,7 +305,7 @@ struct bts_header {
305305
struct bts_action {
306306
u16 type;
307307
u16 size;
308-
u8 data[0];
308+
u8 data[];
309309
} __attribute__ ((packed));
310310

311311
struct bts_action_send {
@@ -315,7 +315,7 @@ struct bts_action_send {
315315
struct bts_action_wait {
316316
u32 msec;
317317
u32 size;
318-
u8 data[0];
318+
u8 data[];
319319
} __attribute__ ((packed));
320320

321321
struct bts_action_delay {

0 commit comments

Comments
 (0)