Skip to content

Commit 4f2bc4a

Browse files
juhosgandersson
authored andcommitted
clk: qcom: clk-alpha-pll: remove invalid Stromer register offset
The offset of the CONFIG_CTL_U register defined for the Stromer PLL is wrong. It is not aligned on a 4 bytes boundary which might causes errors in regmap operations. Maybe the intention behind of using the 0xff value was to indicate that the register is not implemented in the PLL, but this is not verified anywhere in the code. Moreover, this value is not used even in other register offset arrays despite that those PLLs also have unimplemented registers. Additionally, on the Stromer PLLs the current code only touches the CONFIG_CTL_U register if the result of pll_has_64bit_config() is true which condition is not affected by the change. Due to the reasons above, simply remove the CONFIG_CTL_U entry from the Stromer specific array. Fixes: e47a4f5 ("clk: qcom: clk-alpha-pll: Add support for Stromer PLLs") Signed-off-by: Gabor Juhos <[email protected]> Reviewed-by: Konrad Dybcio <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Bjorn Andersson <[email protected]>
1 parent 7ca07a1 commit 4f2bc4a

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

drivers/clk/qcom/clk-alpha-pll.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,6 @@ const u8 clk_alpha_pll_regs[][PLL_OFF_MAX_REGS] = {
213213
[PLL_OFF_USER_CTL] = 0x18,
214214
[PLL_OFF_USER_CTL_U] = 0x1c,
215215
[PLL_OFF_CONFIG_CTL] = 0x20,
216-
[PLL_OFF_CONFIG_CTL_U] = 0xff,
217216
[PLL_OFF_TEST_CTL] = 0x30,
218217
[PLL_OFF_TEST_CTL_U] = 0x34,
219218
[PLL_OFF_STATUS] = 0x28,

0 commit comments

Comments
 (0)