Skip to content

Commit 4f375ad

Browse files
mannkafaiAlexei Starovoitov
authored andcommitted
bpf: Avoid RCU context warning when unpinning htab with internal structs
When unpinning a BPF hash table (htab or htab_lru) that contains internal structures (timer, workqueue, or task_work) in its values, a BUG warning is triggered: BUG: sleeping function called from invalid context at kernel/bpf/hashtab.c:244 in_atomic(): 1, irqs_disabled(): 0, non_block: 0, pid: 14, name: ksoftirqd/0 ... The issue arises from the interaction between BPF object unpinning and RCU callback mechanisms: 1. BPF object unpinning uses ->free_inode() which schedules cleanup via call_rcu(), deferring the actual freeing to an RCU callback that executes within the RCU_SOFTIRQ context. 2. During cleanup of hash tables containing internal structures, htab_map_free_internal_structs() is invoked, which includes cond_resched() or cond_resched_rcu() calls to yield the CPU during potentially long operations. However, cond_resched() or cond_resched_rcu() cannot be safely called from atomic RCU softirq context, leading to the BUG warning when attempting to reschedule. Fix this by changing from ->free_inode() to ->destroy_inode() and rename bpf_free_inode() to bpf_destroy_inode() for BPF objects (prog, map, link). This allows direct inode freeing without RCU callback scheduling, avoiding the invalid context warning. Reported-by: Le Chen <[email protected]> Closes: https://lore.kernel.org/all/[email protected]/ Fixes: 6813466 ("bpf: Add map side support for bpf timers.") Suggested-by: Alexei Starovoitov <[email protected]> Signed-off-by: KaFai Wan <[email protected]> Acked-by: Yonghong Song <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Alexei Starovoitov <[email protected]>
1 parent 07ca98f commit 4f375ad

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

kernel/bpf/inode.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -775,7 +775,7 @@ static int bpf_show_options(struct seq_file *m, struct dentry *root)
775775
return 0;
776776
}
777777

778-
static void bpf_free_inode(struct inode *inode)
778+
static void bpf_destroy_inode(struct inode *inode)
779779
{
780780
enum bpf_type type;
781781

@@ -790,7 +790,7 @@ const struct super_operations bpf_super_ops = {
790790
.statfs = simple_statfs,
791791
.drop_inode = inode_just_drop,
792792
.show_options = bpf_show_options,
793-
.free_inode = bpf_free_inode,
793+
.destroy_inode = bpf_destroy_inode,
794794
};
795795

796796
enum {

0 commit comments

Comments
 (0)