Skip to content

Commit 500c77e

Browse files
Gerhard Englederandy-shev
authored andcommitted
pinctrl: zynqmp: Revert "Unify pin naming"
This reverts commit 54784ff. This patch changes the pin names from "MIO%d" to "MIO-%d", but all dts in arch/arm64/boot/dts/xilinx still use the old name. As a result my ZCU104 has no output on serial terminal and is not reachable over network. Signed-off-by: Gerhard Engleder <[email protected]> Signed-off-by: Andy Shevchenko <[email protected]>
1 parent e12963c commit 500c77e

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

drivers/pinctrl/pinctrl-zynqmp.c

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -809,7 +809,6 @@ static int zynqmp_pinctrl_prepare_pin_desc(struct device *dev,
809809
unsigned int *npins)
810810
{
811811
struct pinctrl_pin_desc *pins, *pin;
812-
char **pin_names;
813812
int ret;
814813
int i;
815814

@@ -821,14 +820,13 @@ static int zynqmp_pinctrl_prepare_pin_desc(struct device *dev,
821820
if (!pins)
822821
return -ENOMEM;
823822

824-
pin_names = devm_kasprintf_strarray(dev, ZYNQMP_PIN_PREFIX, *npins);
825-
if (IS_ERR(pin_names))
826-
return PTR_ERR(pin_names);
827-
828823
for (i = 0; i < *npins; i++) {
829824
pin = &pins[i];
830825
pin->number = i;
831-
pin->name = pin_names[i];
826+
pin->name = devm_kasprintf(dev, GFP_KERNEL, "%s%d",
827+
ZYNQMP_PIN_PREFIX, i);
828+
if (!pin->name)
829+
return -ENOMEM;
832830
}
833831

834832
*zynqmp_pins = pins;

0 commit comments

Comments
 (0)