Skip to content

Commit 5033ad5

Browse files
masahir0ytsbogend
authored andcommitted
MIPS: move unselectable entries out of the "CPU type" choice
Move the following entries out of the "CPU type" choice: - LOONGSON3_ENHANCEMENT - CPU_LOONGSON3_WORKAROUNDS - CPU_LOONGSON3_CPUCFG_EMULATION These entries cannot be selected from the choice because they depend on CPU_LOONGSON64, which is also located in the same choice. In fact, Kconfig does not consider them as choice values because they become children of CPU_LOOONGSON64 due to the automatic submenu creation in menu_finalize(). However, it is hard to understand this behavior unless you are familiar with the Kconfig internals. "choice" should contain only selectable entries. Signed-off-by: Masahiro Yamada <[email protected]> Reviewed-by: Jiaxun Yang <[email protected]> Signed-off-by: Thomas Bogendoerfer <[email protected]>
1 parent 5b7236c commit 5033ad5

File tree

1 file changed

+38
-38
lines changed

1 file changed

+38
-38
lines changed

arch/mips/Kconfig

Lines changed: 38 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -1328,44 +1328,6 @@ config CPU_LOONGSON64
13281328
3B1000, 3B1500, 3A2000, 3A3000 and 3A4000) processors. However, old
13291329
Loongson-2E/2F is not covered here and will be removed in future.
13301330

1331-
config LOONGSON3_ENHANCEMENT
1332-
bool "New Loongson-3 CPU Enhancements"
1333-
default n
1334-
depends on CPU_LOONGSON64
1335-
help
1336-
New Loongson-3 cores (since Loongson-3A R2, as opposed to Loongson-3A
1337-
R1, Loongson-3B R1 and Loongson-3B R2) has many enhancements, such as
1338-
FTLB, L1-VCache, EI/DI/Wait/Prefetch instruction, DSP/DSPr2 ASE, User
1339-
Local register, Read-Inhibit/Execute-Inhibit, SFB (Store Fill Buffer),
1340-
Fast TLB refill support, etc.
1341-
1342-
This option enable those enhancements which are not probed at run
1343-
time. If you want a generic kernel to run on all Loongson 3 machines,
1344-
please say 'N' here. If you want a high-performance kernel to run on
1345-
new Loongson-3 machines only, please say 'Y' here.
1346-
1347-
config CPU_LOONGSON3_WORKAROUNDS
1348-
bool "Loongson-3 LLSC Workarounds"
1349-
default y if SMP
1350-
depends on CPU_LOONGSON64
1351-
help
1352-
Loongson-3 processors have the llsc issues which require workarounds.
1353-
Without workarounds the system may hang unexpectedly.
1354-
1355-
Say Y, unless you know what you are doing.
1356-
1357-
config CPU_LOONGSON3_CPUCFG_EMULATION
1358-
bool "Emulate the CPUCFG instruction on older Loongson cores"
1359-
default y
1360-
depends on CPU_LOONGSON64
1361-
help
1362-
Loongson-3A R4 and newer have the CPUCFG instruction available for
1363-
userland to query CPU capabilities, much like CPUID on x86. This
1364-
option provides emulation of the instruction on older Loongson
1365-
cores, back to Loongson-3A1000.
1366-
1367-
If unsure, please say Y.
1368-
13691331
config CPU_LOONGSON2E
13701332
bool "Loongson 2E"
13711333
depends on SYS_HAS_CPU_LOONGSON2E
@@ -1703,6 +1665,44 @@ config CPU_BMIPS
17031665

17041666
endchoice
17051667

1668+
config LOONGSON3_ENHANCEMENT
1669+
bool "New Loongson-3 CPU Enhancements"
1670+
default n
1671+
depends on CPU_LOONGSON64
1672+
help
1673+
New Loongson-3 cores (since Loongson-3A R2, as opposed to Loongson-3A
1674+
R1, Loongson-3B R1 and Loongson-3B R2) has many enhancements, such as
1675+
FTLB, L1-VCache, EI/DI/Wait/Prefetch instruction, DSP/DSPr2 ASE, User
1676+
Local register, Read-Inhibit/Execute-Inhibit, SFB (Store Fill Buffer),
1677+
Fast TLB refill support, etc.
1678+
1679+
This option enable those enhancements which are not probed at run
1680+
time. If you want a generic kernel to run on all Loongson 3 machines,
1681+
please say 'N' here. If you want a high-performance kernel to run on
1682+
new Loongson-3 machines only, please say 'Y' here.
1683+
1684+
config CPU_LOONGSON3_WORKAROUNDS
1685+
bool "Loongson-3 LLSC Workarounds"
1686+
default y if SMP
1687+
depends on CPU_LOONGSON64
1688+
help
1689+
Loongson-3 processors have the llsc issues which require workarounds.
1690+
Without workarounds the system may hang unexpectedly.
1691+
1692+
Say Y, unless you know what you are doing.
1693+
1694+
config CPU_LOONGSON3_CPUCFG_EMULATION
1695+
bool "Emulate the CPUCFG instruction on older Loongson cores"
1696+
default y
1697+
depends on CPU_LOONGSON64
1698+
help
1699+
Loongson-3A R4 and newer have the CPUCFG instruction available for
1700+
userland to query CPU capabilities, much like CPUID on x86. This
1701+
option provides emulation of the instruction on older Loongson
1702+
cores, back to Loongson-3A1000.
1703+
1704+
If unsure, please say Y.
1705+
17061706
config CPU_MIPS32_3_5_FEATURES
17071707
bool "MIPS32 Release 3.5 Features"
17081708
depends on SYS_HAS_CPU_MIPS32_R3_5

0 commit comments

Comments
 (0)