Skip to content

Commit 506a1ac

Browse files
Dan Carpenterjic23
authored andcommitted
iio: bmi323: fix copy and paste bugs in suspend resume
This code is using bmi323_reg_savestate[] and ->reg_settings[] instead of bmi323_ext_reg_savestate[] and ->ext_reg_settings[]. This was discovered by Smatch: drivers/iio/imu/bmi323/bmi323_core.c:2202 bmi323_core_runtime_suspend() error: buffer overflow 'bmi323_reg_savestate' 9 <= 11 Fixes: 1653111 ("iio: bmi323: peripheral in lowest power state on suspend") Signed-off-by: Dan Carpenter <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jonathan Cameron <[email protected]>
1 parent cd8247c commit 506a1ac

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

drivers/iio/imu/bmi323/bmi323_core.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2198,12 +2198,12 @@ static int bmi323_core_runtime_suspend(struct device *dev)
21982198
}
21992199

22002200
for (unsigned int i = 0; i < ARRAY_SIZE(bmi323_ext_reg_savestate); i++) {
2201-
ret = bmi323_read_ext_reg(data, bmi323_reg_savestate[i],
2202-
&savestate->reg_settings[i]);
2201+
ret = bmi323_read_ext_reg(data, bmi323_ext_reg_savestate[i],
2202+
&savestate->ext_reg_settings[i]);
22032203
if (ret) {
22042204
dev_err(data->dev,
22052205
"Error reading bmi323 external reg 0x%x: %d\n",
2206-
bmi323_reg_savestate[i], ret);
2206+
bmi323_ext_reg_savestate[i], ret);
22072207
return ret;
22082208
}
22092209
}
@@ -2242,12 +2242,12 @@ static int bmi323_core_runtime_resume(struct device *dev)
22422242
}
22432243

22442244
for (unsigned int i = 0; i < ARRAY_SIZE(bmi323_ext_reg_savestate); i++) {
2245-
ret = bmi323_write_ext_reg(data, bmi323_reg_savestate[i],
2246-
savestate->reg_settings[i]);
2245+
ret = bmi323_write_ext_reg(data, bmi323_ext_reg_savestate[i],
2246+
savestate->ext_reg_settings[i]);
22472247
if (ret) {
22482248
dev_err(data->dev,
22492249
"Error writing bmi323 external reg 0x%x: %d\n",
2250-
bmi323_reg_savestate[i], ret);
2250+
bmi323_ext_reg_savestate[i], ret);
22512251
return ret;
22522252
}
22532253
}

0 commit comments

Comments
 (0)