Skip to content

Commit 5072b8e

Browse files
Michael Rieschvinodkoul
authored andcommitted
dt-bindings: phy: rockchip-inno-csi-dphy: add rk3588 variant
The Rockchip RK3588 variant of the CSI-2 DPHY features two reset lines. Add the variant and allow for the additional reset. While at it, fix the description of the first reset in order to avoid confusion. Signed-off-by: Michael Riesch <[email protected]> Reviewed-by: Krzysztof Kozlowski <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Vinod Koul <[email protected]>
1 parent c254815 commit 5072b8e

File tree

1 file changed

+49
-1
lines changed

1 file changed

+49
-1
lines changed

Documentation/devicetree/bindings/phy/rockchip-inno-csi-dphy.yaml

Lines changed: 49 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ properties:
2121
- rockchip,rk3326-csi-dphy
2222
- rockchip,rk3368-csi-dphy
2323
- rockchip,rk3568-csi-dphy
24+
- rockchip,rk3588-csi-dphy
2425

2526
reg:
2627
maxItems: 1
@@ -40,11 +41,15 @@ properties:
4041

4142
resets:
4243
items:
43-
- description: exclusive PHY reset line
44+
- description: APB reset line
45+
- description: PHY reset line
46+
minItems: 1
4447

4548
reset-names:
4649
items:
4750
- const: apb
51+
- const: phy
52+
minItems: 1
4853

4954
rockchip,grf:
5055
$ref: /schemas/types.yaml#/definitions/phandle
@@ -74,6 +79,30 @@ allOf:
7479
then:
7580
required:
7681
- power-domains
82+
- if:
83+
properties:
84+
compatible:
85+
contains:
86+
enum:
87+
- rockchip,px30-csi-dphy
88+
- rockchip,rk1808-csi-dphy
89+
- rockchip,rk3326-csi-dphy
90+
- rockchip,rk3368-csi-dphy
91+
- rockchip,rk3568-csi-dphy
92+
then:
93+
properties:
94+
resets:
95+
maxItems: 1
96+
97+
reset-names:
98+
maxItems: 1
99+
else:
100+
properties:
101+
resets:
102+
minItems: 2
103+
104+
reset-names:
105+
minItems: 2
77106

78107
additionalProperties: false
79108

@@ -91,3 +120,22 @@ examples:
91120
reset-names = "apb";
92121
rockchip,grf = <&grf>;
93122
};
123+
- |
124+
#include <dt-bindings/clock/rockchip,rk3588-cru.h>
125+
#include <dt-bindings/reset/rockchip,rk3588-cru.h>
126+
127+
soc {
128+
#address-cells = <2>;
129+
#size-cells = <2>;
130+
131+
phy@fedc0000 {
132+
compatible = "rockchip,rk3588-csi-dphy";
133+
reg = <0x0 0xfedc0000 0x0 0x8000>;
134+
clocks = <&cru PCLK_CSIPHY0>;
135+
clock-names = "pclk";
136+
#phy-cells = <0>;
137+
resets = <&cru SRST_P_CSIPHY0>, <&cru SRST_CSIPHY0>;
138+
reset-names = "apb", "phy";
139+
rockchip,grf = <&csidphy0_grf>;
140+
};
141+
};

0 commit comments

Comments
 (0)