orangefs: Remove redundant initialization of variable ret

Colin Ian King · hubcapsc · commit 507874c08f63 · 2021-10-11T14:25:21.000-04:00
The variable ret is being initialized with a value that is never read, it
is being updated later on. The assignment is redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King &lt;colin.king@canonical.com&gt;
Signed-off-by: Mike Marshall &lt;hubcap@omnibond.com&gt;
diff --git a/fs/orangefs/super.c b/fs/orangefs/super.c
@@ -475,7 +475,7 @@ struct dentry *orangefs_mount(struct file_system_type *fst,
 			   const char *devname,
 			   void *data)
 {
-	int ret = -EINVAL;
+	int ret;
 	struct super_block *sb = ERR_PTR(-EINVAL);
 	struct orangefs_kernel_op_s *new_op;
 	struct dentry *d = ERR_PTR(-EINVAL);

Original file line number	Diff line number	Diff line change
`@@ -475,7 +475,7 @@ struct dentry orangefs_mount(struct file_system_type fst,`
`475`	`475`	`const char *devname,`
`476`	`476`	`void *data)`
`477`	`477`	`{`
`478`		`- int ret = -EINVAL;`
	`478`	`+ int ret;`
`479`	`479`	`struct super_block *sb = ERR_PTR(-EINVAL);`
`480`	`480`	`struct orangefs_kernel_op_s *new_op;`
`481`	`481`	`struct dentry *d = ERR_PTR(-EINVAL);`