Skip to content

Commit 50ca8cc

Browse files
zackrThomas Zimmermann
authored andcommitted
drm/vmwgfx: Remove unused compile options
Before the driver had screen targets support we had to disable explicit bringup of its infrastructure because it was breaking screen objects support. Since the implementation of screen targets landed there hasn't been a reason to explicitly disable it and the options were never used. Remove of all that unused code. Signed-off-by: Zack Rusin <[email protected]> Fixes: d80efd5 ("drm/vmwgfx: Initial DX support") Reviewed-by: Martin Krastev <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected] (cherry picked from commit 1134309) Signed-off-by: Thomas Zimmermann <[email protected]>
1 parent bc701a2 commit 50ca8cc

File tree

3 files changed

+5
-14
lines changed

3 files changed

+5
-14
lines changed

drivers/gpu/drm/vmwgfx/vmwgfx_drv.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,11 +59,8 @@
5959
#define VMWGFX_DRIVER_MINOR 20
6060
#define VMWGFX_DRIVER_PATCHLEVEL 0
6161
#define VMWGFX_FIFO_STATIC_SIZE (1024*1024)
62-
#define VMWGFX_MAX_RELOCATIONS 2048
63-
#define VMWGFX_MAX_VALIDATIONS 2048
6462
#define VMWGFX_MAX_DISPLAYS 16
6563
#define VMWGFX_CMD_BOUNCE_INIT_SIZE 32768
66-
#define VMWGFX_ENABLE_SCREEN_TARGET_OTABLE 1
6764

6865
#define VMWGFX_PCI_ID_SVGA2 0x0405
6966
#define VMWGFX_PCI_ID_SVGA3 0x0406

drivers/gpu/drm/vmwgfx/vmwgfx_mob.c

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// SPDX-License-Identifier: GPL-2.0 OR MIT
22
/**************************************************************************
33
*
4-
* Copyright 2012-2015 VMware, Inc., Palo Alto, CA., USA
4+
* Copyright 2012-2021 VMware, Inc., Palo Alto, CA., USA
55
*
66
* Permission is hereby granted, free of charge, to any person obtaining a
77
* copy of this software and associated documentation files (the
@@ -29,12 +29,6 @@
2929

3030
#include "vmwgfx_drv.h"
3131

32-
/*
33-
* If we set up the screen target otable, screen objects stop working.
34-
*/
35-
36-
#define VMW_OTABLE_SETUP_SUB ((VMWGFX_ENABLE_SCREEN_TARGET_OTABLE ? 0 : 1))
37-
3832
#ifdef CONFIG_64BIT
3933
#define VMW_PPN_SIZE 8
4034
#define VMW_MOBFMT_PTDEPTH_0 SVGA3D_MOBFMT_PT64_0
@@ -75,7 +69,7 @@ static const struct vmw_otable pre_dx_tables[] = {
7569
{VMWGFX_NUM_GB_CONTEXT * sizeof(SVGAOTableContextEntry), NULL, true},
7670
{VMWGFX_NUM_GB_SHADER * sizeof(SVGAOTableShaderEntry), NULL, true},
7771
{VMWGFX_NUM_GB_SCREEN_TARGET * sizeof(SVGAOTableScreenTargetEntry),
78-
NULL, VMWGFX_ENABLE_SCREEN_TARGET_OTABLE}
72+
NULL, true}
7973
};
8074

8175
static const struct vmw_otable dx_tables[] = {
@@ -84,7 +78,7 @@ static const struct vmw_otable dx_tables[] = {
8478
{VMWGFX_NUM_GB_CONTEXT * sizeof(SVGAOTableContextEntry), NULL, true},
8579
{VMWGFX_NUM_GB_SHADER * sizeof(SVGAOTableShaderEntry), NULL, true},
8680
{VMWGFX_NUM_GB_SCREEN_TARGET * sizeof(SVGAOTableScreenTargetEntry),
87-
NULL, VMWGFX_ENABLE_SCREEN_TARGET_OTABLE},
81+
NULL, true},
8882
{VMWGFX_NUM_DXCONTEXT * sizeof(SVGAOTableDXContextEntry), NULL, true},
8983
};
9084

drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1872,8 +1872,8 @@ int vmw_kms_stdu_init_display(struct vmw_private *dev_priv)
18721872
int i, ret;
18731873

18741874

1875-
/* Do nothing if Screen Target support is turned off */
1876-
if (!VMWGFX_ENABLE_SCREEN_TARGET_OTABLE || !dev_priv->has_mob)
1875+
/* Do nothing if there's no support for MOBs */
1876+
if (!dev_priv->has_mob)
18771877
return -ENOSYS;
18781878

18791879
if (!(dev_priv->capabilities & SVGA_CAP_GBOBJECTS))

0 commit comments

Comments
 (0)