Skip to content

Commit 5136168

Browse files
Christoph Hellwigaxboe
authored andcommitted
block: remove superfluous calls to blkcg_bio_issue_init
blkcg_bio_issue_init is called in submit_bio. There is no need to have extra calls that just get overriden in __bio_clone and the two places that copy and pasted from it. Signed-off-by: Christoph Hellwig <[email protected]> Reviewed-by: Mike Snitzer <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jens Axboe <[email protected]>
1 parent f624506 commit 5136168

File tree

3 files changed

+0
-3
lines changed

3 files changed

+0
-3
lines changed

block/bio.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -768,7 +768,6 @@ static int __bio_clone(struct bio *bio, struct bio *bio_src, gfp_t gfp)
768768
bio->bi_iter = bio_src->bi_iter;
769769

770770
bio_clone_blkg_association(bio, bio_src);
771-
blkcg_bio_issue_init(bio);
772771

773772
if (bio_crypt_clone(bio, bio_src, gfp) < 0)
774773
return -ENOMEM;

block/blk-crypto-fallback.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,6 @@ static struct bio *blk_crypto_fallback_clone_bio(struct bio *bio_src)
179179
bio->bi_io_vec[bio->bi_vcnt++] = bv;
180180

181181
bio_clone_blkg_association(bio, bio_src);
182-
blkcg_bio_issue_init(bio);
183182

184183
return bio;
185184
}

block/bounce.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,6 @@ static struct bio *bounce_clone_bio(struct bio *bio_src)
191191
goto err_put;
192192

193193
bio_clone_blkg_association(bio, bio_src);
194-
blkcg_bio_issue_init(bio);
195194

196195
return bio;
197196

0 commit comments

Comments
 (0)