Skip to content

Commit 513bf56

Browse files
author
Thomas Zimmermann
committed
fbdev/ps3fb: Build without kernel device
Use fb_info() to print status message at the end of the probe function, which avoids decoding the devices. fb_info() works with or without an fbdev kernel device. Fixes the following error: ../drivers/video/fbdev/ps3fb.c: In function 'ps3fb_probe': ../drivers/video/fbdev/ps3fb.c:1172:40: error: 'struct fb_info' has no member named 'dev' 1172 | dev_driver_string(info->dev), dev_name(info->dev), | ^~ ../include/linux/dev_printk.h:110:37: note: in definition of macro 'dev_printk_index_wrap' 110 | _p_func(dev, fmt, ##__VA_ARGS__); \ | ^~~~~~~~~~~ ../drivers/video/fbdev/ps3fb.c:1171:9: note: in expansion of macro 'dev_info' 1171 | dev_info(info->device, "%s %s, using %u KiB of video memory\n", | ^~~~~~~~ ../drivers/video/fbdev/ps3fb.c:1172:61: error: 'struct fb_info' has no member named 'dev' 1172 | dev_driver_string(info->dev), dev_name(info->dev), | ^~ ../include/linux/dev_printk.h:110:37: note: in definition of macro 'dev_printk_index_wrap' 110 | _p_func(dev, fmt, ##__VA_ARGS__); \ | ^~~~~~~~~~~ ../drivers/video/fbdev/ps3fb.c:1171:9: note: in expansion of macro 'dev_info' 1171 | dev_info(info->device, "%s %s, using %u KiB of video memory\n", | ^~~~~~~~ Reported-by: Randy Dunlap <[email protected]> Closes: https://lore.kernel.org/lkml/[email protected]/ Signed-off-by: Thomas Zimmermann <[email protected]> Fixes: 701d205 ("fbdev: Make support for userspace interfaces configurable") Cc: Michael Ellerman <[email protected]> Cc: Sam Ravnborg <[email protected]> Cc: Helge Deller <[email protected]> Cc: Javier Martinez Canillas <[email protected]> Cc: Randy Dunlap <[email protected]> Cc: Bagas Sanjaya <[email protected]> Cc: Thorsten Leemhuis <[email protected]> Cc: [email protected] Cc: [email protected] Cc: [email protected] Acked-by: Sam Ravnborg <[email protected]> Acked-by: Randy Dunlap <[email protected]> Tested-by: Randy Dunlap <[email protected]> # build-tested Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent ad9ee11 commit 513bf56

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

drivers/video/fbdev/ps3fb.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1168,9 +1168,7 @@ static int ps3fb_probe(struct ps3_system_bus_device *dev)
11681168

11691169
ps3_system_bus_set_drvdata(dev, info);
11701170

1171-
dev_info(info->device, "%s %s, using %u KiB of video memory\n",
1172-
dev_driver_string(info->dev), dev_name(info->dev),
1173-
info->fix.smem_len >> 10);
1171+
fb_info(info, "using %u KiB of video memory\n", info->fix.smem_len >> 10);
11741172

11751173
task = kthread_run(ps3fbd, info, DEVICE_NAME);
11761174
if (IS_ERR(task)) {

0 commit comments

Comments
 (0)