Skip to content

Commit 517c649

Browse files
Michael Rubingregkh
authored andcommitted
staging: gpib: ines: struct gpib_board
Using Linux code style for struct gpib_board. Adhering to Linux code style. In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin <[email protected]> Acked-By: Dave Penkler <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent b35e450 commit 517c649

File tree

2 files changed

+83
-82
lines changed

2 files changed

+83
-82
lines changed

drivers/staging/gpib/ines/ines.h

Lines changed: 27 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -36,41 +36,41 @@ struct ines_priv {
3636
};
3737

3838
// interface functions
39-
int ines_read(gpib_board_t *board, uint8_t *buffer, size_t length, int *end, size_t *bytes_read);
40-
int ines_write(gpib_board_t *board, uint8_t *buffer, size_t length,
39+
int ines_read(struct gpib_board *board, uint8_t *buffer, size_t length, int *end, size_t *bytes_read);
40+
int ines_write(struct gpib_board *board, uint8_t *buffer, size_t length,
4141
int send_eoi, size_t *bytes_written);
42-
int ines_accel_read(gpib_board_t *board, uint8_t *buffer, size_t length,
42+
int ines_accel_read(struct gpib_board *board, uint8_t *buffer, size_t length,
4343
int *end, size_t *bytes_read);
44-
int ines_accel_write(gpib_board_t *board, uint8_t *buffer, size_t length,
44+
int ines_accel_write(struct gpib_board *board, uint8_t *buffer, size_t length,
4545
int send_eoi, size_t *bytes_written);
46-
int ines_command(gpib_board_t *board, uint8_t *buffer, size_t length, size_t *bytes_written);
47-
int ines_take_control(gpib_board_t *board, int synchronous);
48-
int ines_go_to_standby(gpib_board_t *board);
49-
void ines_request_system_control(gpib_board_t *board, int request_control);
50-
void ines_interface_clear(gpib_board_t *board, int assert);
51-
void ines_remote_enable(gpib_board_t *board, int enable);
52-
int ines_enable_eos(gpib_board_t *board, uint8_t eos_byte, int compare_8_bits);
53-
void ines_disable_eos(gpib_board_t *board);
54-
unsigned int ines_update_status(gpib_board_t *board, unsigned int clear_mask);
55-
int ines_primary_address(gpib_board_t *board, unsigned int address);
56-
int ines_secondary_address(gpib_board_t *board, unsigned int address, int enable);
57-
int ines_parallel_poll(gpib_board_t *board, uint8_t *result);
58-
void ines_parallel_poll_configure(gpib_board_t *board, uint8_t config);
59-
void ines_parallel_poll_response(gpib_board_t *board, int ist);
60-
void ines_serial_poll_response(gpib_board_t *board, uint8_t status);
61-
uint8_t ines_serial_poll_status(gpib_board_t *board);
62-
int ines_line_status(const gpib_board_t *board);
63-
unsigned int ines_t1_delay(gpib_board_t *board, unsigned int nano_sec);
64-
void ines_return_to_local(gpib_board_t *board);
46+
int ines_command(struct gpib_board *board, uint8_t *buffer, size_t length, size_t *bytes_written);
47+
int ines_take_control(struct gpib_board *board, int synchronous);
48+
int ines_go_to_standby(struct gpib_board *board);
49+
void ines_request_system_control(struct gpib_board *board, int request_control);
50+
void ines_interface_clear(struct gpib_board *board, int assert);
51+
void ines_remote_enable(struct gpib_board *board, int enable);
52+
int ines_enable_eos(struct gpib_board *board, uint8_t eos_byte, int compare_8_bits);
53+
void ines_disable_eos(struct gpib_board *board);
54+
unsigned int ines_update_status(struct gpib_board *board, unsigned int clear_mask);
55+
int ines_primary_address(struct gpib_board *board, unsigned int address);
56+
int ines_secondary_address(struct gpib_board *board, unsigned int address, int enable);
57+
int ines_parallel_poll(struct gpib_board *board, uint8_t *result);
58+
void ines_parallel_poll_configure(struct gpib_board *board, uint8_t config);
59+
void ines_parallel_poll_response(struct gpib_board *board, int ist);
60+
void ines_serial_poll_response(struct gpib_board *board, uint8_t status);
61+
uint8_t ines_serial_poll_status(struct gpib_board *board);
62+
int ines_line_status(const struct gpib_board *board);
63+
unsigned int ines_t1_delay(struct gpib_board *board, unsigned int nano_sec);
64+
void ines_return_to_local(struct gpib_board *board);
6565

6666
// interrupt service routines
6767
irqreturn_t ines_pci_interrupt(int irq, void *arg);
68-
irqreturn_t ines_interrupt(gpib_board_t *board);
68+
irqreturn_t ines_interrupt(struct gpib_board *board);
6969

7070
// utility functions
71-
void ines_free_private(gpib_board_t *board);
72-
int ines_generic_attach(gpib_board_t *board);
73-
void ines_online(struct ines_priv *priv, const gpib_board_t *board, int use_accel);
71+
void ines_free_private(struct gpib_board *board);
72+
int ines_generic_attach(struct gpib_board *board);
73+
void ines_online(struct ines_priv *priv, const struct gpib_board *board, int use_accel);
7474
void ines_set_xfer_counter(struct ines_priv *priv, unsigned int count);
7575

7676
/* inb/outb wrappers */

0 commit comments

Comments
 (0)