Skip to content

Commit 51859c5

Browse files
committed
Merge tag 'locking-urgent-2024-08-25' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
Pull locking fix from Thomas Gleixner: "A single fix for rt_mutex. The deadlock detection code drops into an infinite scheduling loop while still holding rt_mutex::wait_lock, which rightfully triggers a 'scheduling in atomic' warning. Unlock it before that" * tag 'locking-urgent-2024-08-25' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip: rtmutex: Drop rt_mutex::wait_lock before scheduling
2 parents 9a75429 + d33d260 commit 51859c5

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

kernel/locking/rtmutex.c

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1644,6 +1644,7 @@ static int __sched rt_mutex_slowlock_block(struct rt_mutex_base *lock,
16441644
}
16451645

16461646
static void __sched rt_mutex_handle_deadlock(int res, int detect_deadlock,
1647+
struct rt_mutex_base *lock,
16471648
struct rt_mutex_waiter *w)
16481649
{
16491650
/*
@@ -1656,10 +1657,10 @@ static void __sched rt_mutex_handle_deadlock(int res, int detect_deadlock,
16561657
if (build_ww_mutex() && w->ww_ctx)
16571658
return;
16581659

1659-
/*
1660-
* Yell loudly and stop the task right here.
1661-
*/
1660+
raw_spin_unlock_irq(&lock->wait_lock);
1661+
16621662
WARN(1, "rtmutex deadlock detected\n");
1663+
16631664
while (1) {
16641665
set_current_state(TASK_INTERRUPTIBLE);
16651666
rt_mutex_schedule();
@@ -1713,7 +1714,7 @@ static int __sched __rt_mutex_slowlock(struct rt_mutex_base *lock,
17131714
} else {
17141715
__set_current_state(TASK_RUNNING);
17151716
remove_waiter(lock, waiter);
1716-
rt_mutex_handle_deadlock(ret, chwalk, waiter);
1717+
rt_mutex_handle_deadlock(ret, chwalk, lock, waiter);
17171718
}
17181719

17191720
/*

0 commit comments

Comments
 (0)