udp6: fix udp6_ehashfn() typo

edumazet · davem330 · commit 51d03e2f2203 · 2023-07-08T15:20:48.000+01:00
Amit Klein reported that udp6_ehash_secret was initialized but never used. Fixes: 1bbdcee ("inet: convert inet_ehash_secret and ipv6_hash_secret to net_get_random_once") Reported-by: Amit Klein <aksecurity@gmail.com> Signed-off-by: Eric Dumazet <edumazet@google.com> Cc: Willy Tarreau <w@1wt.eu> Cc: Willem de Bruijn <willemdebruijn.kernel@gmail.com> Cc: David Ahern <dsahern@kernel.org> Cc: Hannes Frederic Sowa <hannes@stressinduktion.org> Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/net/ipv6/udp.c b/net/ipv6/udp.c
@@ -91,7 +91,7 @@ static u32 udp6_ehashfn(const struct net *net,
 	fhash = __ipv6_addr_jhash(faddr, udp_ipv6_hash_secret);
 
 	return __inet6_ehashfn(lhash, lport, fhash, fport,
-			       udp_ipv6_hash_secret + net_hash_mix(net));
+			       udp6_ehash_secret + net_hash_mix(net));
 }
 
 int udp_v6_get_port(struct sock *sk, unsigned short snum)

Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,7 @@ static u32 udp6_ehashfn(const struct net *net,`
`91`	`91`	`fhash = __ipv6_addr_jhash(faddr, udp_ipv6_hash_secret);`
`92`	`92`
`93`	`93`	`return __inet6_ehashfn(lhash, lport, fhash, fport,`
`94`		`- udp_ipv6_hash_secret + net_hash_mix(net));`
	`94`	`+ udp6_ehash_secret + net_hash_mix(net));`
`95`	`95`	`}`
`96`	`96`
`97`	`97`	`int udp_v6_get_port(struct sock *sk, unsigned short snum)`