Skip to content

Commit 51dfe71

Browse files
asdfugilWim Van Sebroeck
authored andcommitted
watchdog: apple: Actually flush writes after requesting watchdog restart
Although there is an existing code comment about flushing the writes, writes were not actually being flushed. Actually flush the writes by changing readl_relaxed() to readl(). Fixes: 4ed224a ("watchdog: Add Apple SoC watchdog driver") Suggested-by: Arnd Bergmann <[email protected]> Signed-off-by: Nick Chan <[email protected]> Reviewed-by: Guenter Roeck <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Guenter Roeck <[email protected]> Signed-off-by: Wim Van Sebroeck <[email protected]>
1 parent 3ab1663 commit 51dfe71

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/watchdog/apple_wdt.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ static int apple_wdt_restart(struct watchdog_device *wdd, unsigned long mode,
130130
* can take up to ~20-25ms until the SoC is actually reset. Just wait
131131
* 50ms here to be safe.
132132
*/
133-
(void)readl_relaxed(wdt->regs + APPLE_WDT_WD1_CUR_TIME);
133+
(void)readl(wdt->regs + APPLE_WDT_WD1_CUR_TIME);
134134
mdelay(50);
135135

136136
return 0;

0 commit comments

Comments
 (0)