drm/i915/rpm: Enable runtime pm autosuspend by default

tttangud · rodrigovivi · commit 527bab0473f2 · 2021-11-22T09:06:37.000-05:00
Let's enable runtime pm autosuspend by default everywhere. So, we can allow D3hot and bigger power savings on idle scenarios. But at this time let's not touch the autosuspend_delay time, what caused some regression on our previous attempt. Also, the latest identified issue on GuC PM has been fixed by commit 1a52fae ("drm/i915/guc: Take GT PM ref when deregistering context") v1: Enable runtime pm autosuspend by default for Gen12 and later versions. v2: Enable runtime pm autosuspend by default for all platforms(Syrjala Ville) v3: Change commit message(Nikula Jani) Signed-off-by: Tilak Tangudu <tilak.tangudu@intel.com> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20211116155238.3226516-1-tilak.tangudu@intel.com
diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c
@@ -600,6 +600,9 @@ void intel_runtime_pm_enable(struct intel_runtime_pm *rpm)
 		pm_runtime_use_autosuspend(kdev);
 	}
 
+	/* Enable by default */
+	pm_runtime_allow(kdev);
+
 	/*
 	 * The core calls the driver load handler with an RPM reference held.
 	 * We drop that here and will reacquire it during unloading in

Original file line number	Diff line number	Diff line change
`@@ -600,6 +600,9 @@ void intel_runtime_pm_enable(struct intel_runtime_pm *rpm)`
`600`	`600`	`pm_runtime_use_autosuspend(kdev);`
`601`	`601`	`}`
`602`	`602`
	`603`	`+ /* Enable by default */`
	`604`	`+ pm_runtime_allow(kdev);`
	`605`	`+`
`603`	`606`	`/*`
`604`	`607`	`* The core calls the driver load handler with an RPM reference held.`
`605`	`608`	`* We drop that here and will reacquire it during unloading in`