Skip to content

Commit 52909f1

Browse files
ConchuODpalmer-dabbelt
authored andcommitted
RISC-V: drop error print from riscv_hartid_to_cpuid()
As of commit 2ac8743 ("RISC-V: split early & late of_node to hartid mapping") my CI complains about newly added pr_err() messages during boot, for example: [ 0.000000] Couldn't find cpu id for hartid [0] [ 0.000000] riscv-intc: unable to find hart id for /cpus/cpu@0/interrupt-controller Before the split, riscv_of_processor_hartid() contained a check for whether the cpu was "available", before calling riscv_hartid_to_cpuid(), but after the split riscv_of_processor_hartid() can be called for cpus that are disabled. Most callers of riscv_hartid_to_cpuid() already report custom errors where it falls, making this print superfluous in those case. In other places, the print adds nothing - see riscv_intc_init() for example. Fixes: 2ac8743 ("RISC-V: split early & late of_node to hartid mapping") Signed-off-by: Conor Dooley <[email protected]> Link: https://lore.kernel.org/r/20230629-paternity-grafted-b901b76d04a0@wendy Signed-off-by: Palmer Dabbelt <[email protected]>
1 parent 9657e9b commit 52909f1

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

arch/riscv/kernel/smp.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@ int riscv_hartid_to_cpuid(unsigned long hartid)
5858
if (cpuid_to_hartid_map(i) == hartid)
5959
return i;
6060

61-
pr_err("Couldn't find cpu id for hartid [%lu]\n", hartid);
6261
return -ENOENT;
6362
}
6463

0 commit comments

Comments
 (0)