Skip to content

Commit 52c74d1

Browse files
jdelvarewsakernel
authored andcommitted
i2c: i801: Drop two outdated comments
* Timeouts are reported even in interrupt mode since commit b3b8df9 ("i2c: i801: Use wait_event_timeout to wait for interrupts") so drop the comment which claims this only happens in polled mode. * xact does not include the PEC bit, as the driver does not support software PEC. Signed-off-by: Jean Delvare <[email protected]> Reviewed-by: Jarkko Nikula <[email protected]> Signed-off-by: Wolfram Sang <[email protected]>
1 parent 1d366c2 commit 52c74d1

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

drivers/i2c/busses/i2c-i801.c

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -364,9 +364,6 @@ static int i801_check_post(struct i801_priv *priv, int status)
364364

365365
/*
366366
* If the SMBus is still busy, we give up
367-
* Note: This timeout condition only happens when using polling
368-
* transactions. For interrupt operation, NAK/timeout is indicated by
369-
* DEV_ERR.
370367
*/
371368
if (unlikely(status < 0)) {
372369
dev_err(&priv->pci_dev->dev, "Transaction timeout\n");
@@ -475,8 +472,6 @@ static int i801_transaction(struct i801_priv *priv, int xact)
475472
return i801_check_post(priv, result ? priv->status : -ETIMEDOUT);
476473
}
477474

478-
/* the current contents of SMBHSTCNT can be overwritten, since PEC,
479-
* SMBSCMD are passed in xact */
480475
outb_p(xact | SMBHSTCNT_START, SMBHSTCNT(priv));
481476

482477
status = i801_wait_intr(priv);

0 commit comments

Comments
 (0)