Skip to content

Commit 52cf891

Browse files
committed
Merge tag 'kvm-riscv-5.16-2' of https://github.com/kvm-riscv/linux into HEAD
Minor cocci warning fixes: 1) Bool return warning fix 2) Unnedded semicolon warning fix
2 parents 9c6eb53 + bbd5ba8 commit 52cf891

File tree

5 files changed

+17
-17
lines changed

5 files changed

+17
-17
lines changed

arch/riscv/kvm/mmu.c

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -565,12 +565,12 @@ int kvm_arch_prepare_memory_region(struct kvm *kvm,
565565
bool kvm_unmap_gfn_range(struct kvm *kvm, struct kvm_gfn_range *range)
566566
{
567567
if (!kvm->arch.pgd)
568-
return 0;
568+
return false;
569569

570570
stage2_unmap_range(kvm, range->start << PAGE_SHIFT,
571571
(range->end - range->start) << PAGE_SHIFT,
572572
range->may_block);
573-
return 0;
573+
return false;
574574
}
575575

576576
bool kvm_set_spte_gfn(struct kvm *kvm, struct kvm_gfn_range *range)
@@ -579,18 +579,18 @@ bool kvm_set_spte_gfn(struct kvm *kvm, struct kvm_gfn_range *range)
579579
kvm_pfn_t pfn = pte_pfn(range->pte);
580580

581581
if (!kvm->arch.pgd)
582-
return 0;
582+
return false;
583583

584584
WARN_ON(range->end - range->start != 1);
585585

586586
ret = stage2_map_page(kvm, NULL, range->start << PAGE_SHIFT,
587587
__pfn_to_phys(pfn), PAGE_SIZE, true, true);
588588
if (ret) {
589589
kvm_debug("Failed to map stage2 page (error %d)\n", ret);
590-
return 1;
590+
return true;
591591
}
592592

593-
return 0;
593+
return false;
594594
}
595595

596596
bool kvm_age_gfn(struct kvm *kvm, struct kvm_gfn_range *range)
@@ -600,13 +600,13 @@ bool kvm_age_gfn(struct kvm *kvm, struct kvm_gfn_range *range)
600600
u64 size = (range->end - range->start) << PAGE_SHIFT;
601601

602602
if (!kvm->arch.pgd)
603-
return 0;
603+
return false;
604604

605605
WARN_ON(size != PAGE_SIZE && size != PMD_SIZE && size != PGDIR_SIZE);
606606

607607
if (!stage2_get_leaf_entry(kvm, range->start << PAGE_SHIFT,
608608
&ptep, &ptep_level))
609-
return 0;
609+
return false;
610610

611611
return ptep_test_and_clear_young(NULL, 0, ptep);
612612
}
@@ -618,13 +618,13 @@ bool kvm_test_age_gfn(struct kvm *kvm, struct kvm_gfn_range *range)
618618
u64 size = (range->end - range->start) << PAGE_SHIFT;
619619

620620
if (!kvm->arch.pgd)
621-
return 0;
621+
return false;
622622

623623
WARN_ON(size != PAGE_SIZE && size != PMD_SIZE && size != PGDIR_SIZE);
624624

625625
if (!stage2_get_leaf_entry(kvm, range->start << PAGE_SHIFT,
626626
&ptep, &ptep_level))
627-
return 0;
627+
return false;
628628

629629
return pte_young(*ptep);
630630
}

arch/riscv/kvm/vcpu.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ static int kvm_riscv_vcpu_get_reg_config(struct kvm_vcpu *vcpu,
164164
break;
165165
default:
166166
return -EINVAL;
167-
};
167+
}
168168

169169
if (copy_to_user(uaddr, &reg_val, KVM_REG_SIZE(reg->id)))
170170
return -EFAULT;
@@ -201,7 +201,7 @@ static int kvm_riscv_vcpu_set_reg_config(struct kvm_vcpu *vcpu,
201201
break;
202202
default:
203203
return -EINVAL;
204-
};
204+
}
205205

206206
return 0;
207207
}

arch/riscv/kvm/vcpu_exit.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -394,7 +394,7 @@ static int emulate_store(struct kvm_vcpu *vcpu, struct kvm_run *run,
394394
break;
395395
default:
396396
return -EOPNOTSUPP;
397-
};
397+
}
398398

399399
/* Update MMIO details in kvm_run struct */
400400
run->mmio.is_write = true;
@@ -642,7 +642,7 @@ int kvm_riscv_vcpu_mmio_return(struct kvm_vcpu *vcpu, struct kvm_run *run)
642642
break;
643643
default:
644644
return -EOPNOTSUPP;
645-
};
645+
}
646646

647647
done:
648648
/* Move to next instruction */
@@ -684,7 +684,7 @@ int kvm_riscv_vcpu_exit(struct kvm_vcpu *vcpu, struct kvm_run *run,
684684
break;
685685
default:
686686
break;
687-
};
687+
}
688688

689689
/* Print details in-case of error */
690690
if (ret < 0) {

arch/riscv/kvm/vcpu_sbi.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ int kvm_riscv_vcpu_sbi_ecall(struct kvm_vcpu *vcpu, struct kvm_run *run)
166166
/* Return error for unsupported SBI calls */
167167
cp->a0 = SBI_ERR_NOT_SUPPORTED;
168168
break;
169-
};
169+
}
170170

171171
if (next_sepc)
172172
cp->sepc += 4;

arch/riscv/kvm/vcpu_timer.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ int kvm_riscv_vcpu_get_reg_timer(struct kvm_vcpu *vcpu,
120120
break;
121121
default:
122122
return -EINVAL;
123-
};
123+
}
124124

125125
if (copy_to_user(uaddr, &reg_val, KVM_REG_SIZE(reg->id)))
126126
return -EFAULT;
@@ -167,7 +167,7 @@ int kvm_riscv_vcpu_set_reg_timer(struct kvm_vcpu *vcpu,
167167
default:
168168
ret = -EINVAL;
169169
break;
170-
};
170+
}
171171

172172
return ret;
173173
}

0 commit comments

Comments
 (0)