Skip to content

Commit 52fbe17

Browse files
ribaldamchehab
authored andcommitted
media: uvcvideo: Invert default value for nodrop module param
The module param `nodrop` defines what to do with frames that contain an error: drop them or sending them to userspace. The default in the rest of the media subsystem is to return buffers with an error to userspace with V4L2_BUF_FLAG_ERROR set in v4l2_buffer.flags. In UVC we drop buffers with errors by default. Change the default behaviour of uvcvideo to match the rest of the drivers and maybe get rid of the module parameter in the future. Suggested-by: Laurent Pinchart <[email protected]> Signed-off-by: Ricardo Ribalda <[email protected]> Reviewed-by: Laurent Pinchart <[email protected]> Reviewed-by: Hans de Goede <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Laurent Pinchart <[email protected]> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
1 parent 87ce177 commit 52fbe17

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/media/usb/uvc/uvc_driver.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232

3333
unsigned int uvc_clock_param = CLOCK_MONOTONIC;
3434
unsigned int uvc_hw_timestamps_param;
35-
unsigned int uvc_no_drop_param;
35+
unsigned int uvc_no_drop_param = 1;
3636
static unsigned int uvc_quirks_param = -1;
3737
unsigned int uvc_dbg_param;
3838
unsigned int uvc_timeout_param = UVC_CTRL_STREAMING_TIMEOUT;

0 commit comments

Comments
 (0)