Skip to content

Commit 53661de

Browse files
abattersbymartinkpetersen
authored andcommitted
scsi: qla2xxx: Disable ATIO interrupt coalesce for quad port ISP27XX
This partially reverts commit d2b292c ("scsi: qla2xxx: Enable ATIO interrupt handshake for ISP27XX") For some workloads where the host sends a batch of commands and then pauses, ATIO interrupt coalesce can cause some incoming ATIO entries to be ignored for extended periods of time, resulting in slow performance, timeouts, and aborted commands. Disable interrupt coalesce and re-enable the dedicated ATIO MSI-X interrupt. Link: https://lore.kernel.org/r/[email protected] Reviewed-by: Himanshu Madhani <[email protected]> Reviewed-by: Nilesh Javali <[email protected]> Signed-off-by: Tony Battersby <[email protected]> Signed-off-by: Martin K. Petersen <[email protected]>
1 parent c6380f9 commit 53661de

File tree

1 file changed

+2
-8
lines changed

1 file changed

+2
-8
lines changed

drivers/scsi/qla2xxx/qla_target.c

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6935,14 +6935,8 @@ qlt_24xx_config_rings(struct scsi_qla_host *vha)
69356935

69366936
if (ha->flags.msix_enabled) {
69376937
if (IS_QLA83XX(ha) || IS_QLA27XX(ha) || IS_QLA28XX(ha)) {
6938-
if (IS_QLA2071(ha)) {
6939-
/* 4 ports Baker: Enable Interrupt Handshake */
6940-
icb->msix_atio = 0;
6941-
icb->firmware_options_2 |= cpu_to_le32(BIT_26);
6942-
} else {
6943-
icb->msix_atio = cpu_to_le16(msix->entry);
6944-
icb->firmware_options_2 &= cpu_to_le32(~BIT_26);
6945-
}
6938+
icb->msix_atio = cpu_to_le16(msix->entry);
6939+
icb->firmware_options_2 &= cpu_to_le32(~BIT_26);
69466940
ql_dbg(ql_dbg_init, vha, 0xf072,
69476941
"Registering ICB vector 0x%x for atio que.\n",
69486942
msix->entry);

0 commit comments

Comments
 (0)