Skip to content

Commit 536e785

Browse files
VARoDeKwsakernel
authored andcommitted
i2c: eg20t: Drop PCI wakeup calls from .suspend/.resume
The driver calls pci_enable_wake(...., false) in pch_i2c_suspend() as well as pch_i2c_resume(). Either it should enable-wake the device in .suspend() or should not invoke pci_enable_wake() at all. Concluding that this driver doesn't support enable-wake and PCI core calls pci_enable_wake(pci_dev, PCI_D0, false) during resume, drop it from .suspend() and .resume(). Reported-by: Bjorn Helgaas <[email protected]> Signed-off-by: Vaibhav Gupta <[email protected]> Reviewed-by: Bjorn Helgaas <[email protected]> Signed-off-by: Wolfram Sang <[email protected]>
1 parent b0102a8 commit 536e785

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

drivers/i2c/busses/i2c-eg20t.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -879,7 +879,6 @@ static int pch_i2c_suspend(struct pci_dev *pdev, pm_message_t state)
879879
return ret;
880880
}
881881

882-
pci_enable_wake(pdev, PCI_D3hot, 0);
883882
pci_disable_device(pdev);
884883
pci_set_power_state(pdev, pci_choose_state(pdev, state));
885884

@@ -899,8 +898,6 @@ static int pch_i2c_resume(struct pci_dev *pdev)
899898
return -EIO;
900899
}
901900

902-
pci_enable_wake(pdev, PCI_D3hot, 0);
903-
904901
for (i = 0; i < adap_info->ch_num; i++)
905902
pch_i2c_init(&adap_info->pch_data[i]);
906903

0 commit comments

Comments
 (0)