Skip to content

Commit 537bddd

Browse files
badgeriousaegl
authored andcommitted
EDAC/sb_edac: Fix top-of-high-memory value for Broadwell/Haswell
The computation of TOHM is off by one bit. This missed bit results in too low a value for TOHM, which can cause errors in regular memory to incorrectly report: EDAC MC0: 1 CE Error at MMIOH area, on addr 0x000000207fffa680 on any memory Fixes: 50d1bb9 ("sb_edac: add support for Haswell based systems") Cc: [email protected] Reported-by: Meeta Saggi <[email protected]> Signed-off-by: Eric Badger <[email protected]> Signed-off-by: Tony Luck <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent 0b6d4ab commit 537bddd

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/edac/sb_edac.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1052,7 +1052,7 @@ static u64 haswell_get_tohm(struct sbridge_pvt *pvt)
10521052
pci_read_config_dword(pvt->info.pci_vtd, HASWELL_TOHM_1, &reg);
10531053
rc = ((reg << 6) | rc) << 26;
10541054

1055-
return rc | 0x1ffffff;
1055+
return rc | 0x3ffffff;
10561056
}
10571057

10581058
static u64 knl_get_tolm(struct sbridge_pvt *pvt)

0 commit comments

Comments
 (0)