Skip to content

Commit 5415bec

Browse files
author
Thomas Zimmermann
committed
drm/mgag200: Force 32 bpp on the console
G200ER does not seem to support 24 bpp, so force the console to use 32 bpp. The problem got introduced when commit 73f54d5 ("drm/mgag200: Remove special case for G200SE with <2 MiB") changed the preferred color depth from 32 bit to 24 bit. A setting of 24 is the correct color depth, but G200ER doesn't seem to be able to use the respective RGB888 color format. Using 24-bit color with forced 32 bpp works around the problem. Reported-by: Wang Yugui <[email protected]> Signed-off-by: Thomas Zimmermann <[email protected]> Tested-by: Wang Yugui <[email protected]> Reviewed-by: Jocelyn Falempe <[email protected]> Fixes: 73f54d5 ("drm/mgag200: Remove special case for G200SE with <2 MiB") Cc: Thomas Zimmermann <[email protected]> Cc: Jocelyn Falempe <[email protected]> Cc: Dave Airlie <[email protected]> Cc: [email protected] Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent a7c48a0 commit 5415bec

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

drivers/gpu/drm/mgag200/mgag200_drv.c

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -262,7 +262,11 @@ mgag200_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
262262
if (ret)
263263
return ret;
264264

265-
drm_fbdev_generic_setup(dev, 0);
265+
/*
266+
* FIXME: A 24-bit color depth does not work with 24 bpp on
267+
* G200ER. Force 32 bpp.
268+
*/
269+
drm_fbdev_generic_setup(dev, 32);
266270

267271
return 0;
268272
}

0 commit comments

Comments
 (0)