Skip to content

Commit 5422d87

Browse files
z00467499ickle
authored andcommitted
drm/i915: Fix too few arguments to function i915_capture_error_state
If 'CONFIG_DRM_I915_CAPTURE_ERROR' not configured, there is an error when compile the kernel: drivers/gpu/drm/i915/gt/intel_reset.c: In function intel_gt_handle_error: drivers/gpu/drm/i915/gt/intel_reset.c:1233:3: error: too few arguments to function i915_capture_error_state i915_capture_error_state(gt->i915); ^~~~~~~~~~~~~~~~~~~~~~~~ In file included from ./drivers/gpu/drm/i915/i915_drv.h:97:0, from ./drivers/gpu/drm/i915/display/intel_display_types.h:46, from drivers/gpu/drm/i915/gt/intel_reset.c:10: ./drivers/gpu/drm/i915/i915_gpu_error.h:267:20: note: declared here static inline void i915_capture_error_state(struct drm_i915_private *dev_priv, Fixes: 742379c ("drm/i915: Start chopping up the GPU error capture") Reported-by: Hulk Robot <[email protected]> Signed-off-by: Zhang Xiaoxu <[email protected]> Reviewed-by: Chris Wilson <[email protected]> Signed-off-by: Chris Wilson <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent 59be9b9 commit 5422d87

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

drivers/gpu/drm/i915/i915_gpu_error.h

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ __printf(2, 3)
212212
void i915_error_printf(struct drm_i915_error_state_buf *e, const char *f, ...);
213213

214214
struct i915_gpu_coredump *i915_gpu_coredump(struct drm_i915_private *i915);
215-
void i915_capture_error_state(struct drm_i915_private *dev_priv);
215+
void i915_capture_error_state(struct drm_i915_private *i915);
216216

217217
struct i915_gpu_coredump *
218218
i915_gpu_coredump_alloc(struct drm_i915_private *i915, gfp_t gfp);
@@ -264,9 +264,7 @@ void i915_disable_error_state(struct drm_i915_private *i915, int err);
264264

265265
#else
266266

267-
static inline void i915_capture_error_state(struct drm_i915_private *dev_priv,
268-
u32 engine_mask,
269-
const char *error_msg)
267+
static inline void i915_capture_error_state(struct drm_i915_private *i915)
270268
{
271269
}
272270

0 commit comments

Comments
 (0)