Skip to content

Commit 5429b51

Browse files
davejiangvinodkoul
authored andcommitted
dmaengine: fix null ptr check for __dma_async_device_channel_register()
Add check to pointer after assignment before accessing members. Fixes: d2fb0a0: ("dmaengine: break out channel registration") Reported-by: Dan Carpenter <[email protected]> Signed-off-by: Dave Jiang <[email protected]> Link: https://lore.kernel.org/r/158049351973.45445.3291586905226032744.stgit@djiang5-desk3.ch.intel.com Signed-off-by: Vinod Koul <[email protected]>
1 parent a9113a9 commit 5429b51

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

drivers/dma/dmaengine.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -962,6 +962,9 @@ static int __dma_async_device_channel_register(struct dma_device *device,
962962

963963
tchan = list_first_entry_or_null(&device->channels,
964964
struct dma_chan, device_node);
965+
if (!tchan)
966+
return -ENODEV;
967+
965968
if (tchan->dev) {
966969
idr_ref = tchan->dev->idr_ref;
967970
} else {

0 commit comments

Comments
 (0)