Skip to content

Commit 5433f0e

Browse files
superm1floatious
authored andcommitted
ata: Kconfig: Update SATA_MOBILE_LPM_POLICY default to med_power_with_dipm
Historically this was set to "keep_firmware_settings" to prevent problems with power management on very old drives. However it's been observed that almost all modern Linux distributions either set the policy to "med_power_with_dipm" in the kernel configuration or update it to this via userspace policy changes. Update the policy default in the kernel to "med_power_with_dipm" to match that behavior as well. Changing the default was previously not a good idea, because LPM disables detection of hot plug removals, however, since commit ae1f3db ("ata: ahci: do not enable LPM on external ports"), a port marked as external will always be initialized to "keep_firmware_settings", regardless of the SATA_MOBILE_LPM_POLICY Kconfig value. Therefore, changing the default is now considered safe (external ports included). Reviewed-by: Damien Le Moal <[email protected]> Signed-off-by: Mario Limonciello <[email protected]> [cassel: rebased and reworded commit message] Signed-off-by: Niklas Cassel <[email protected]>
1 parent 1613e60 commit 5433f0e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/ata/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ config SATA_AHCI
118118
config SATA_MOBILE_LPM_POLICY
119119
int "Default SATA Link Power Management policy"
120120
range 0 4
121-
default 0
121+
default 3
122122
depends on SATA_AHCI
123123
help
124124
Select the Default SATA Link Power Management (LPM) policy to use

0 commit comments

Comments
 (0)