Skip to content

Commit 54343d9

Browse files
committed
Merge tag 'scsi-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi
Pull SCSI fixes from James Bottomley: "Two last minute fixes, both in drivers. The fnic one is a highly unlikely condition, but the RDMA one is a recently introduced regression that causes a kernel warning to trigger in every RDMA logon, which would be unsightly if it got into the final release" * tag 'scsi-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi: scsi: RDMA/isert: Fix a recently introduced regression related to logout scsi: fnic: do not queue commands during fwreset
2 parents b1b2989 + 04060db commit 54343d9

File tree

3 files changed

+6
-15
lines changed

3 files changed

+6
-15
lines changed

drivers/infiniband/ulp/isert/ib_isert.c

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2575,17 +2575,6 @@ isert_wait4logout(struct isert_conn *isert_conn)
25752575
}
25762576
}
25772577

2578-
static void
2579-
isert_wait4cmds(struct iscsi_conn *conn)
2580-
{
2581-
isert_info("iscsi_conn %p\n", conn);
2582-
2583-
if (conn->sess) {
2584-
target_sess_cmd_list_set_waiting(conn->sess->se_sess);
2585-
target_wait_for_sess_cmds(conn->sess->se_sess);
2586-
}
2587-
}
2588-
25892578
/**
25902579
* isert_put_unsol_pending_cmds() - Drop commands waiting for
25912580
* unsolicitate dataout
@@ -2633,7 +2622,6 @@ static void isert_wait_conn(struct iscsi_conn *conn)
26332622

26342623
ib_drain_qp(isert_conn->qp);
26352624
isert_put_unsol_pending_cmds(conn);
2636-
isert_wait4cmds(conn);
26372625
isert_wait4logout(isert_conn);
26382626

26392627
queue_work(isert_release_wq, &isert_conn->release_work);

drivers/scsi/fnic/fnic_scsi.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -439,6 +439,9 @@ static int fnic_queuecommand_lck(struct scsi_cmnd *sc, void (*done)(struct scsi_
439439
if (unlikely(fnic_chk_state_flags_locked(fnic, FNIC_FLAGS_IO_BLOCKED)))
440440
return SCSI_MLQUEUE_HOST_BUSY;
441441

442+
if (unlikely(fnic_chk_state_flags_locked(fnic, FNIC_FLAGS_FWRESET)))
443+
return SCSI_MLQUEUE_HOST_BUSY;
444+
442445
rport = starget_to_rport(scsi_target(sc->device));
443446
if (!rport) {
444447
FNIC_SCSI_DBG(KERN_DEBUG, fnic->lport->host,

drivers/target/iscsi/iscsi_target.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4149,9 +4149,6 @@ int iscsit_close_connection(
41494149
iscsit_stop_nopin_response_timer(conn);
41504150
iscsit_stop_nopin_timer(conn);
41514151

4152-
if (conn->conn_transport->iscsit_wait_conn)
4153-
conn->conn_transport->iscsit_wait_conn(conn);
4154-
41554152
/*
41564153
* During Connection recovery drop unacknowledged out of order
41574154
* commands for this connection, and prepare the other commands
@@ -4237,6 +4234,9 @@ int iscsit_close_connection(
42374234
target_sess_cmd_list_set_waiting(sess->se_sess);
42384235
target_wait_for_sess_cmds(sess->se_sess);
42394236

4237+
if (conn->conn_transport->iscsit_wait_conn)
4238+
conn->conn_transport->iscsit_wait_conn(conn);
4239+
42404240
ahash_request_free(conn->conn_tx_hash);
42414241
if (conn->conn_rx_hash) {
42424242
struct crypto_ahash *tfm;

0 commit comments

Comments
 (0)