Skip to content

Commit 54b8644

Browse files
ChristianKoenigAMDalexdeucher
authored andcommitted
drm/amdgpu: explicitely set the AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS flag
Instead of having that in the amdgpu_bo_pin() function applied for all pinned BOs. Signed-off-by: Christian König <[email protected]> Acked-by: Lijo Lazar <[email protected]> Signed-off-by: Alex Deucher <[email protected]>
1 parent 42ac749 commit 54b8644

File tree

9 files changed

+13
-1
lines changed

9 files changed

+13
-1
lines changed

drivers/gpu/drm/amd/amdgpu/amdgpu_display.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -233,6 +233,7 @@ int amdgpu_display_crtc_page_flip_target(struct drm_crtc *crtc,
233233
}
234234

235235
if (!adev->enable_virtual_display) {
236+
new_abo->flags |= AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS;
236237
r = amdgpu_bo_pin(new_abo,
237238
amdgpu_display_supported_domains(adev, new_abo->flags));
238239
if (unlikely(r != 0)) {
@@ -1759,6 +1760,7 @@ int amdgpu_display_resume_helper(struct amdgpu_device *adev)
17591760

17601761
r = amdgpu_bo_reserve(aobj, true);
17611762
if (r == 0) {
1763+
aobj->flags |= AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS;
17621764
r = amdgpu_bo_pin(aobj, AMDGPU_GEM_DOMAIN_VRAM);
17631765
if (r != 0)
17641766
dev_err(adev->dev, "Failed to pin cursor BO (%d)\n", r);

drivers/gpu/drm/amd/amdgpu/amdgpu_object.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -942,7 +942,6 @@ int amdgpu_bo_pin_restricted(struct amdgpu_bo *bo, u32 domain,
942942
*/
943943
int amdgpu_bo_pin(struct amdgpu_bo *bo, u32 domain)
944944
{
945-
bo->flags |= AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS;
946945
return amdgpu_bo_pin_restricted(bo, domain, 0, 0);
947946
}
948947

drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -338,6 +338,7 @@ static int amdgpu_vkms_prepare_fb(struct drm_plane *plane,
338338
else
339339
domain = AMDGPU_GEM_DOMAIN_VRAM;
340340

341+
rbo->flags |= AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS;
341342
r = amdgpu_bo_pin(rbo, domain);
342343
if (unlikely(r != 0)) {
343344
if (r != -ERESTARTSYS)

drivers/gpu/drm/amd/amdgpu/dce_v10_0.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1881,6 +1881,7 @@ static int dce_v10_0_crtc_do_set_base(struct drm_crtc *crtc,
18811881
return r;
18821882

18831883
if (!atomic) {
1884+
abo->flags |= AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS;
18841885
r = amdgpu_bo_pin(abo, AMDGPU_GEM_DOMAIN_VRAM);
18851886
if (unlikely(r != 0)) {
18861887
amdgpu_bo_unreserve(abo);
@@ -2401,6 +2402,7 @@ static int dce_v10_0_crtc_cursor_set2(struct drm_crtc *crtc,
24012402
return ret;
24022403
}
24032404

2405+
aobj->flags |= AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS;
24042406
ret = amdgpu_bo_pin(aobj, AMDGPU_GEM_DOMAIN_VRAM);
24052407
amdgpu_bo_unreserve(aobj);
24062408
if (ret) {

drivers/gpu/drm/amd/amdgpu/dce_v11_0.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1931,6 +1931,7 @@ static int dce_v11_0_crtc_do_set_base(struct drm_crtc *crtc,
19311931
return r;
19321932

19331933
if (!atomic) {
1934+
abo->flags |= AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS;
19341935
r = amdgpu_bo_pin(abo, AMDGPU_GEM_DOMAIN_VRAM);
19351936
if (unlikely(r != 0)) {
19361937
amdgpu_bo_unreserve(abo);
@@ -2485,6 +2486,7 @@ static int dce_v11_0_crtc_cursor_set2(struct drm_crtc *crtc,
24852486
return ret;
24862487
}
24872488

2489+
aobj->flags |= AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS;
24882490
ret = amdgpu_bo_pin(aobj, AMDGPU_GEM_DOMAIN_VRAM);
24892491
amdgpu_bo_unreserve(aobj);
24902492
if (ret) {

drivers/gpu/drm/amd/amdgpu/dce_v6_0.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1861,6 +1861,7 @@ static int dce_v6_0_crtc_do_set_base(struct drm_crtc *crtc,
18611861
return r;
18621862

18631863
if (!atomic) {
1864+
abo->flags |= AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS;
18641865
r = amdgpu_bo_pin(abo, AMDGPU_GEM_DOMAIN_VRAM);
18651866
if (unlikely(r != 0)) {
18661867
amdgpu_bo_unreserve(abo);
@@ -2321,6 +2322,7 @@ static int dce_v6_0_crtc_cursor_set2(struct drm_crtc *crtc,
23212322
return ret;
23222323
}
23232324

2325+
aobj->flags |= AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS;
23242326
ret = amdgpu_bo_pin(aobj, AMDGPU_GEM_DOMAIN_VRAM);
23252327
amdgpu_bo_unreserve(aobj);
23262328
if (ret) {

drivers/gpu/drm/amd/amdgpu/dce_v8_0.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1828,6 +1828,7 @@ static int dce_v8_0_crtc_do_set_base(struct drm_crtc *crtc,
18281828
return r;
18291829

18301830
if (!atomic) {
1831+
abo->flags |= AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS;
18311832
r = amdgpu_bo_pin(abo, AMDGPU_GEM_DOMAIN_VRAM);
18321833
if (unlikely(r != 0)) {
18331834
amdgpu_bo_unreserve(abo);
@@ -2320,6 +2321,7 @@ static int dce_v8_0_crtc_cursor_set2(struct drm_crtc *crtc,
23202321
return ret;
23212322
}
23222323

2324+
aobj->flags |= AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS;
23232325
ret = amdgpu_bo_pin(aobj, AMDGPU_GEM_DOMAIN_VRAM);
23242326
amdgpu_bo_unreserve(aobj);
23252327
if (ret) {

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -961,6 +961,7 @@ static int amdgpu_dm_plane_helper_prepare_fb(struct drm_plane *plane,
961961
else
962962
domain = AMDGPU_GEM_DOMAIN_VRAM;
963963

964+
rbo->flags |= AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS;
964965
r = amdgpu_bo_pin(rbo, domain);
965966
if (unlikely(r != 0)) {
966967
if (r != -ERESTARTSYS)

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,7 @@ static int amdgpu_dm_wb_prepare_job(struct drm_writeback_connector *wb_connector
114114

115115
domain = amdgpu_display_supported_domains(adev, rbo->flags);
116116

117+
rbo->flags |= AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS;
117118
r = amdgpu_bo_pin(rbo, domain);
118119
if (unlikely(r != 0)) {
119120
if (r != -ERESTARTSYS)

0 commit comments

Comments
 (0)