Skip to content

Commit 54ee394

Browse files
sassmannanguy11
authored andcommitted
iavf: fix double unlock of crit_lock
The crit_lock mutex could be unlocked twice as reported here https://lists.osuosl.org/pipermail/intel-wired-lan/Week-of-Mon-20210823/025525.html Remove the superfluous unlock. Technically the problem was already present before 5ac49f3 as that commit only replaced the locking primitive, but no functional change. Reported-by: Dan Carpenter <[email protected]> Fixes: 5ac49f3 ("iavf: use mutexes for locking of critical sections") Fixes: bac8486 ("iavf: Refactor the watchdog state machine") Signed-off-by: Stefan Assmann <[email protected]> Signed-off-by: Tony Nguyen <[email protected]>
1 parent 2e5a205 commit 54ee394

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

drivers/net/ethernet/intel/iavf/iavf_main.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1965,7 +1965,6 @@ static void iavf_watchdog_task(struct work_struct *work)
19651965
}
19661966
adapter->aq_required = 0;
19671967
adapter->current_op = VIRTCHNL_OP_UNKNOWN;
1968-
mutex_unlock(&adapter->crit_lock);
19691968
queue_delayed_work(iavf_wq,
19701969
&adapter->watchdog_task,
19711970
msecs_to_jiffies(10));

0 commit comments

Comments
 (0)