Skip to content

Commit 5521055

Browse files
spandruvadarafaeljw
authored andcommitted
cpufreq: intel_pstate: Fix unchecked MSR 0x773 access
It is possible that on some platforms HWP interrupts are disabled. In that case accessing MSR 0x773 will result in warning. So check X86_FEATURE_HWP_NOTIFY feature to access MSR 0x773. The other places in code where this MSR is accessed, already checks this feature except during disable path called during cpufreq offline and suspend callbacks. Fixes: 57577c9 ("cpufreq: intel_pstate: Process HWP Guaranteed change notification") Reported-by: Steven Rostedt <[email protected]> Signed-off-by: Srinivas Pandruvada <[email protected]> Tested-by: Steven Rostedt (VMware) <[email protected]> Signed-off-by: Rafael J. Wysocki <[email protected]>
1 parent dbea75f commit 5521055

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

drivers/cpufreq/intel_pstate.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1627,6 +1627,9 @@ static void intel_pstate_disable_hwp_interrupt(struct cpudata *cpudata)
16271627
{
16281628
unsigned long flags;
16291629

1630+
if (!boot_cpu_has(X86_FEATURE_HWP_NOTIFY))
1631+
return;
1632+
16301633
/* wrmsrl_on_cpu has to be outside spinlock as this can result in IPC */
16311634
wrmsrl_on_cpu(cpudata->cpu, MSR_HWP_INTERRUPT, 0x00);
16321635

0 commit comments

Comments
 (0)