Skip to content

Commit 55354ee

Browse files
Wang Mingpinchartl
authored andcommitted
drm: xlnx: zynqmp_dpsub: Use dev_err_probe instead of dev_err
It is possible that dma_request_chan() returns EPROBE_DEFER, in which case the driver defers probing without printing any message. Use dev_err_probe() to record the probe deferral cause and ease debugging. Signed-off-by: Wang Ming <[email protected]> Reviewed-by: Laurent Pinchart <[email protected]> Signed-off-by: Laurent Pinchart <[email protected]>
1 parent 1832fba commit 55354ee

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/gpu/drm/xlnx/zynqmp_disp.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1094,8 +1094,8 @@ static int zynqmp_disp_layer_request_dma(struct zynqmp_disp *disp,
10941094
"%s%u", dma_names[layer->id], i);
10951095
dma->chan = dma_request_chan(disp->dev, dma_channel_name);
10961096
if (IS_ERR(dma->chan)) {
1097-
dev_err(disp->dev, "failed to request dma channel\n");
1098-
ret = PTR_ERR(dma->chan);
1097+
ret = dev_err_probe(disp->dev, PTR_ERR(dma->chan),
1098+
"failed to request dma channel\n");
10991099
dma->chan = NULL;
11001100
return ret;
11011101
}

0 commit comments

Comments
 (0)