Skip to content

Commit 553845e

Browse files
ammarfaizi2t-8ch
authored andcommitted
tools/nolibc: x86-64: Use rep movsb for memcpy() and memmove()
Simplify memcpy() and memmove() on the x86-64 arch. The x86-64 arch has a 'rep movsb' instruction, which can perform memcpy() using only a single instruction, given: %rdi = destination %rsi = source %rcx = length Additionally, it can also handle the overlapping case by setting DF=1 (backward copy), which can be used as the memmove() implementation. Before this patch: ``` 00000000000010ab <memmove>: 10ab: 48 89 f8 mov %rdi,%rax 10ae: 31 c9 xor %ecx,%ecx 10b0: 48 39 f7 cmp %rsi,%rdi 10b3: 48 83 d1 ff adc $0xffffffffffffffff,%rcx 10b7: 48 85 d2 test %rdx,%rdx 10ba: 74 25 je 10e1 <memmove+0x36> 10bc: 48 83 c9 01 or $0x1,%rcx 10c0: 48 39 f0 cmp %rsi,%rax 10c3: 48 c7 c7 ff ff ff ff mov $0xffffffffffffffff,%rdi 10ca: 48 0f 43 fa cmovae %rdx,%rdi 10ce: 48 01 cf add %rcx,%rdi 10d1: 44 8a 04 3e mov (%rsi,%rdi,1),%r8b 10d5: 44 88 04 38 mov %r8b,(%rax,%rdi,1) 10d9: 48 01 cf add %rcx,%rdi 10dc: 48 ff ca dec %rdx 10df: 75 f0 jne 10d1 <memmove+0x26> 10e1: c3 ret 00000000000010e2 <memcpy>: 10e2: 48 89 f8 mov %rdi,%rax 10e5: 48 85 d2 test %rdx,%rdx 10e8: 74 12 je 10fc <memcpy+0x1a> 10ea: 31 c9 xor %ecx,%ecx 10ec: 40 8a 3c 0e mov (%rsi,%rcx,1),%dil 10f0: 40 88 3c 08 mov %dil,(%rax,%rcx,1) 10f4: 48 ff c1 inc %rcx 10f7: 48 39 ca cmp %rcx,%rdx 10fa: 75 f0 jne 10ec <memcpy+0xa> 10fc: c3 ret ``` After this patch: ``` // memmove is an alias for memcpy 000000000040133b <memcpy>: 40133b: 48 89 d1 mov %rdx,%rcx 40133e: 48 89 f8 mov %rdi,%rax 401341: 48 89 fa mov %rdi,%rdx 401344: 48 29 f2 sub %rsi,%rdx 401347: 48 39 ca cmp %rcx,%rdx 40134a: 72 03 jb 40134f <memcpy+0x14> 40134c: f3 a4 rep movsb %ds:(%rsi),%es:(%rdi) 40134e: c3 ret 40134f: 48 8d 7c 0f ff lea -0x1(%rdi,%rcx,1),%rdi 401354: 48 8d 74 0e ff lea -0x1(%rsi,%rcx,1),%rsi 401359: fd std 40135a: f3 a4 rep movsb %ds:(%rsi),%es:(%rdi) 40135c: fc cld 40135d: c3 ret ``` v3: - Make memmove as an alias for memcpy (Willy). - Make the forward copy the likely case (Alviro). v2: - Fix the broken memmove implementation (David). Link: https://lore.kernel.org/lkml/[email protected] Link: https://lore.kernel.org/lkml/[email protected] Suggested-by: David Laight <[email protected]> Signed-off-by: Ammar Faizi <[email protected]> Signed-off-by: Willy Tarreau <[email protected]> Signed-off-by: Thomas Weißschuh <[email protected]>
1 parent 265fbb4 commit 553845e

File tree

2 files changed

+33
-0
lines changed

2 files changed

+33
-0
lines changed

tools/include/nolibc/arch-x86_64.h

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -173,4 +173,33 @@ void __attribute__((weak, noreturn, optimize("Os", "omit-frame-pointer"))) __no_
173173
__builtin_unreachable();
174174
}
175175

176+
#define NOLIBC_ARCH_HAS_MEMMOVE
177+
void *memmove(void *dst, const void *src, size_t len);
178+
179+
#define NOLIBC_ARCH_HAS_MEMCPY
180+
void *memcpy(void *dst, const void *src, size_t len);
181+
182+
__asm__ (
183+
".section .text.nolibc_memmove_memcpy\n"
184+
".weak memmove\n"
185+
".weak memcpy\n"
186+
"memmove:\n"
187+
"memcpy:\n"
188+
"movq %rdx, %rcx\n\t"
189+
"movq %rdi, %rax\n\t"
190+
"movq %rdi, %rdx\n\t"
191+
"subq %rsi, %rdx\n\t"
192+
"cmpq %rcx, %rdx\n\t"
193+
"jb .Lbackward_copy\n\t"
194+
"rep movsb\n\t"
195+
"retq\n"
196+
".Lbackward_copy:"
197+
"leaq -1(%rdi, %rcx, 1), %rdi\n\t"
198+
"leaq -1(%rsi, %rcx, 1), %rsi\n\t"
199+
"std\n\t"
200+
"rep movsb\n\t"
201+
"cld\n\t"
202+
"retq\n"
203+
);
204+
176205
#endif /* _NOLIBC_ARCH_X86_64_H */

tools/include/nolibc/string.h

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ void *_nolibc_memcpy_down(void *dst, const void *src, size_t len)
4949
return dst;
5050
}
5151

52+
#ifndef NOLIBC_ARCH_HAS_MEMMOVE
5253
/* might be ignored by the compiler without -ffreestanding, then found as
5354
* missing.
5455
*/
@@ -72,13 +73,16 @@ void *memmove(void *dst, const void *src, size_t len)
7273
}
7374
return dst;
7475
}
76+
#endif /* #ifndef NOLIBC_ARCH_HAS_MEMMOVE */
7577

78+
#ifndef NOLIBC_ARCH_HAS_MEMCPY
7679
/* must be exported, as it's used by libgcc on ARM */
7780
__attribute__((weak,unused,section(".text.nolibc_memcpy")))
7881
void *memcpy(void *dst, const void *src, size_t len)
7982
{
8083
return _nolibc_memcpy_up(dst, src, len);
8184
}
85+
#endif /* #ifndef NOLIBC_ARCH_HAS_MEMCPY */
8286

8387
/* might be ignored by the compiler without -ffreestanding, then found as
8488
* missing.

0 commit comments

Comments
 (0)