Skip to content

Commit 5618303

Browse files
z00467499smfrench
authored andcommitted
cifs: update ctime and mtime during truncate
As the man description of the truncate, if the size changed, then the st_ctime and st_mtime fields should be updated. But in cifs, we doesn't do it. It lead the xfstests generic/313 failed. So, add the ATTR_MTIME|ATTR_CTIME flags on attrs when change the file size Reported-by: Hulk Robot <[email protected]> Signed-off-by: Zhang Xiaoxu <[email protected]> Signed-off-by: Steve French <[email protected]>
1 parent acc91c2 commit 5618303

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

fs/cifs/inode.c

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2535,6 +2535,15 @@ cifs_set_file_size(struct inode *inode, struct iattr *attrs,
25352535
if (rc == 0) {
25362536
cifsInode->server_eof = attrs->ia_size;
25372537
cifs_setsize(inode, attrs->ia_size);
2538+
2539+
/*
2540+
* The man page of truncate says if the size changed,
2541+
* then the st_ctime and st_mtime fields for the file
2542+
* are updated.
2543+
*/
2544+
attrs->ia_ctime = attrs->ia_mtime = current_time(inode);
2545+
attrs->ia_valid |= ATTR_CTIME | ATTR_MTIME;
2546+
25382547
cifs_truncate_page(inode->i_mapping, inode->i_size);
25392548
}
25402549

0 commit comments

Comments
 (0)